I know the second case was missed, that will be updated.
I agree calculating the remaining buffer space is more straightforward
here without the library so I'll go with that approach in a v4 of the
series.
Thanks for the detailed feedback.
On 2/14/2023 9:11 AM, Gerd Hoffmann wrote:
Hi,
[ ... details snipped ... ]
I'd prefer it if the code were updated to avoid SafeUintnAdd() altogether.
But if not, then at a minimum the redundant check should be removed, and the
calculation involving Smbios.Hdr->Length should also be updated to use
SafeUintnAdd().
Fully agreeing to that.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100182): https://edk2.groups.io/g/devel/message/100182
Mute This Topic: https://groups.io/mt/96938294/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
