Using a global is not compatible with XIP code where only const globals are 
supported.

A module of type BASE is considered compatible with XIP components.


Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gerd Hoffmann
> Sent: Wednesday, March 1, 2023 1:07 AM
> To: Warkentin, Andrei <andrei.warken...@intel.com>
> Cc: devel@edk2.groups.io; Daniel Schaefer <g...@danielschaefer.me>; Sunil V L 
> <suni...@ventanamicro.com>
> Subject: Re: [edk2-devel] [edk2 2/2] MdePkg: add BaseSerialPortLibRiscVSbi
> 
> On Wed, Mar 01, 2023 at 08:50:38AM +0000, Warkentin, Andrei wrote:
> > The library caller could call Poll() first,
> 
> Ah, Poll is part of the library API, not just an internal helper.
> Ok, makes sense then.
> 
> series:
> Acked-by: Gerd Hoffmann <kra...@redhat.com>
> 
> take care,
>   Gerd
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100600): https://edk2.groups.io/g/devel/message/100600
Mute This Topic: https://groups.io/mt/97309875/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: 
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to