On Fri, Mar 03, 2023 at 12:04:10PM -0600, Andrei Warkentin wrote: > If the SerialPortLib had any initialization needed, this > would be skipped in the RiscVVirt Sec. Follow the example > seen elsewhere (ArmVirtPkg PrePi). > > Seen with BaseSerialPortLibRiscVSbi not using DBCN in Sec, yet > using DBCN elsewhere. > > Cc: Daniel Schaefer <g...@danielschaefer.me> > Cc: Sunil V L <suni...@ventanamicro.com> > Signed-off-by: Andrei Warkentin <andrei.warken...@intel.com> > --- > OvmfPkg/RiscVVirt/Sec/SecMain.inf | 1 + > OvmfPkg/RiscVVirt/Sec/SecMain.h | 1 + > OvmfPkg/RiscVVirt/Sec/SecMain.c | 4 +++- > 3 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.inf > b/OvmfPkg/RiscVVirt/Sec/SecMain.inf > index aed35d3af596..0e2a5785e8a4 100644 > --- a/OvmfPkg/RiscVVirt/Sec/SecMain.inf > +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.inf > @@ -48,6 +48,7 @@ [LibraryClasses] > FdtLib > MemoryAllocationLib > HobLib > + SerialPortLib > > [Ppis] > gEfiTemporaryRamSupportPpiGuid # PPI ALWAYS_PRODUCED > diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.h b/OvmfPkg/RiscVVirt/Sec/SecMain.h > index 83a8058efe40..7c7650f0d298 100644 > --- a/OvmfPkg/RiscVVirt/Sec/SecMain.h > +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.h > @@ -29,6 +29,7 @@ > #include <Library/PrePiLib.h> > #include <Library/PlatformInitLib.h> > #include <Library/PrePiHobListPointerLib.h> > +#include <Library/SerialPortLib.h> > #include <Register/RiscV64/RiscVImpl.h> > > /** > diff --git a/OvmfPkg/RiscVVirt/Sec/SecMain.c b/OvmfPkg/RiscVVirt/Sec/SecMain.c > index adf73f2eb66c..db309ebdf1a3 100644 > --- a/OvmfPkg/RiscVVirt/Sec/SecMain.c > +++ b/OvmfPkg/RiscVVirt/Sec/SecMain.c > @@ -1,7 +1,7 @@ > /** @file > RISC-V SEC phase module for Qemu Virt. > > - Copyright (c) 2008 - 2015, Intel Corporation. All rights reserved.<BR> > + Copyright (c) 2008 - 2013, Intel Corporation. All rights reserved.<BR> Should be 2008 - 2023
Otherwise, LGTM. Reviewed-by: Sunil V L <suni...@ventanamicro.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100987): https://edk2.groups.io/g/devel/message/100987 Mute This Topic: https://groups.io/mt/97368169/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-