Agree with both comments😊 > -----Original Message----- > From: Gerd Hoffmann <kra...@redhat.com> > Sent: Monday, March 13, 2023 4:00 PM > To: Tom Lendacky <thomas.lenda...@amd.com> > Cc: devel@edk2.groups.io; Dong, Eric <eric.d...@intel.com>; Ni, Ray > <ray...@intel.com>; Kumar, Rahul R <rahul.r.ku...@intel.com>; Michael > Roth <michael.r...@amd.com>; Ashish Kalra <ashish.ka...@amd.com> > Subject: Re: [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA > allocations are not 2MB aligned > > Hi, > > > // Allocate a single page for the SEV-ES Save Area and initialize it. > > + // Due to an erratum that prevents a VMSA being on a 2MB boundary, > > + // allocate an extra page to work around the issue. > > A reference to the erratum (web link or erratum id) would be nice here. > Also swapping the order of the two patches might simplify the other > patch which happens to shuffle around the code this patch has just > added. > > take care, > Gerd
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101082): https://edk2.groups.io/g/devel/message/101082 Mute This Topic: https://groups.io/mt/97524218/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
