Did you make sure the change would really fix the issue? Just add the DEPX would only make sure the protocol is installed but not installed to the image handle. The return value would be still error code. And the issue is still there.
The HII image related protocol should not be the MUST have for the application. Using the DEBUG ASSERT is not appropriate. I would suggest to remove the ASSERT instead. Thanks, Zhichao From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Sheng Lean Tan Sent: Thursday, March 16, 2023 12:54 AM To: devel@edk2.groups.io; Rudolph, Patrick <patrick.rudo...@9elements.com>; Gao, Zhichao <zhichao....@intel.com> Cc: Dong, Guo <guo.d...@intel.com>; Ni, Ray <ray...@intel.com>; Rhodes, Sean <sean@starlabs.systems>; Lu, James <james...@intel.com>; Guo, Gua <gua....@intel.com> Subject: Re: [edk2-devel] [PATCH 3/3] ShellPkg/TftpDynamicCommand.inf: Add missing DEPEX Added Zhichao. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101255): https://edk2.groups.io/g/devel/message/101255 Mute This Topic: https://groups.io/mt/97421038/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
