Am 28.11.22 um 06:40 schrieb Gerd Hoffmann: > Instead of using hard-coded strings ("0.0.0" for BiosVersion etc) > which is mostly useless read the PCDs (PcdFirmwareVendor, > PcdFirmwareVersionString and PcdFirmwareReleaseDateString) and > build the string table dynamuically at runtime. > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 6 + > .../XenSmbiosPlatformDxe.inf | 9 +- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 115 +++++++++++------- > 3 files changed, 85 insertions(+), 45 deletions(-) >
Hi, after this patch, certain SMBIOS values are different[2]. We got a report that the different vendor causes issues with hardware keys[0]. And, as I learned from the patch fixing it, the missing date can cause issues with Windows[1]. To keep backwards compatibility for [0], it's necessary for us to specify the old vendor value during build. I assume this will affect other downstream distributors too. Since we base our packaging off Debian, I asked there for how to best handle it and am now passing along the question I got in return: Am 29.03.23 um 18:51 schrieb dann frazier: > It'd be > good to understand what upstream's intention was there - are they > expecting each distributor to set our own values, and if so, is there > a scheme we should follow? Best Regards, Fiona [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=4625 [1]: https://edk2.groups.io/g/devel/message/100922 [2]: dmidecode output differences in a Linux guest when running with a build with OvmfPkg/OvmfPkgIa32X64.dsc: edk2-stable202205: Vendor: EFI Development Kit II / OVMF Version: 0.0.0 Release Date: 02/06/2015 edk2-stable202302: Vendor: EDK II Version: unknown Release Date: unknown -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#102160): https://edk2.groups.io/g/devel/message/102160 Mute This Topic: https://groups.io/mt/95304965/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-