On 3/29/23 21:26, Ni, Ray wrote:
Tom,
I would assume this won't break any AMD system because the CPUID bit doesn't
declare this feature.
Right, shouldn't be an issue on AMD systems.
Though it does bring to mind that we should probably do something similar
for AMD at some point. With SEV there is a 1-bit physical address
reduction (reported via CPUID) in the guest (but it should only be
reported in CPUID if the encryption bit is part of the reported max
physical address).
Thanks,
Tom
Gerd,
This is needed by Intel platform for TME-MK. Can you help to analyze if it has
any impact to OVMF? I assume no.
Thanks,
Ray
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
Sent: Tuesday, March 28, 2023 10:10 PM
To: devel@edk2.groups.io
Cc: 'Gerd Hoffmann' <kra...@redhat.com>; Tom Lendacky <thomas.lenda...@amd.com>
Subject: Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max
PA
Gerd, Tom,
Can you please review this patch series?
thanks,
ray
________________________________
From: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
<devel@edk2.groups.io<mailto:devel@edk2.groups.io>> on behalf of Ni, Ray
<ray...@intel.com<mailto:ray...@intel.com>>
Sent: Wednesday, March 22, 2023 7:56:44 AM
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
<devel@edk2.groups.io<mailto:devel@edk2.groups.io>>
Subject: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA
Ray Ni (6):
MdePkg: Add TME-MK related CPUID and MSR definitions
UefiCpuPkg/MtrrTest: Only claim CPUID max leaf as 1
UefiCpuPkg/MtrrLib: Substract TME-MK KEY_ID_BITS from CPU max PA
UefiCpuPkg/CpuDxe: Refactor to use CPUID definitions
UefiCpuPkg/CpuDxe: Substract TME-MK KEY_ID_BITS from CPU max PA
UefiCpuPkg/MtrrTest: Add test cases for TME-MK enable case
.../Include/Register/Intel/ArchitecturalMsr.h | 106 ++++++++++++++-
MdePkg/Include/Register/Intel/Cpuid.h | 9 +-
UefiCpuPkg/CpuDxe/CpuDxe.c | 38 ++++--
UefiCpuPkg/CpuDxe/CpuDxe.h | 3 +-
UefiCpuPkg/Library/MtrrLib/MtrrLib.c | 24 +++-
.../MtrrLib/UnitTest/MtrrLibUnitTest.c | 18 +--
.../MtrrLib/UnitTest/MtrrLibUnitTest.h | 3 +-
UefiCpuPkg/Library/MtrrLib/UnitTest/Support.c | 126 ++++++++++++++----
8 files changed, 278 insertions(+), 49 deletions(-)
--
2.39.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102192): https://edk2.groups.io/g/devel/message/102192
Mute This Topic: https://groups.io/mt/97767965/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
