[AMD Official Use Only - General]
Reviewed-by: Abner Chang <abner.ch...@amd.com>
> -----Original Message-----
> From: Abdul Lateef Attar <abdat...@amd.com>
> Sent: Monday, April 3, 2023 7:23 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) <abdullateef.at...@amd.com>; Ard
> Biesheuvel <ardb+tianoc...@kernel.org>; Leif Lindholm
> <quic_llind...@quicinc.com>; Chang, Abner <abner.ch...@amd.com>;
> Michael D Kinney <michael.d.kin...@intel.com>
> Subject: [PATCH v4 2/3] Platform/AMD/MinBoardPkg: Adds SetCacheMtrrLib
> library
>
> Adds SetCacheMtrrLib library for AmdMinBoardPkg, which sets MTRR values
> for PEI phase and also modifies the MTRR value at the end of PEI phase.
>
> Signed-off-by: Abdul Lateef Attar <abdat...@amd.com>
> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
> Cc: Leif Lindholm <quic_llind...@quicinc.com>
> Cc: Abner Chang <abner.ch...@amd.com>
> Cc: Michael D Kinney <michael.d.kin...@intel.com>
> ---
> .../AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc | 9 ++
> .../SetCacheMtrrLib/SetCacheMtrrLib.inf | 35 +++++
> .../Library/SetCacheMtrrLib/SetCacheMtrrLib.c | 133 ++++++++++++++++++
> 3 files changed, 177 insertions(+)
> create mode 100644
> Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib
> .inf
> create mode 100644
> Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib
> .c
>
> diff --git a/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc
> b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc
> index 74992a9a6b8c..2f17db5df5fb 100644
> --- a/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc
> +++ b/Platform/AMD/AmdMinBoardPkg/AmdMinBoardPkg.dsc
> @@ -18,4 +18,13 @@ [Defines]
>
> [Packages]
> AmdMinBoardPkg/AmdMinBoardPkg.dec
> + MdePkg/MdePkg.dec
> + MinPlatformPkg/MinPlatformPkg.dec
> + UefiCpuPkg/UefiCpuPkg.dec
> +
> +[LibraryClasses.common.PEIM]
> +
> +SetCacheMtrrLib|AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtr
> rLib.
> +inf
> +
> +[Components.IA32]
> + AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrrLib.inf
>
> diff --git
> a/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrr
> Lib.inf
> b/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrr
> Lib.inf
> new file mode 100644
> index 000000000000..b4c4b3e7de14
> --- /dev/null
> +++
> b/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrr
> Li
> +++ b.inf
> @@ -0,0 +1,35 @@
> +## @file
> +# Component information file for Platform SetCacheMtrr Library.
> +# This library implementation is for AMD processor based platforms.
> +#
> +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> +reserved.<BR> # # SPDX-License-Identifier: BSD-2-Clause-Patent # ##
> +
> +[Defines]
> + INF_VERSION = 1.29
> + BASE_NAME = PeiSetCacheMtrrLib
> + FILE_GUID = 1E8468E0-5EB4-4088-9B52-BFDC6E4DAE87
> + MODULE_TYPE = PEIM
> + VERSION_STRING = 1.0
> + LIBRARY_CLASS = SetCacheMtrrLib
> +
> +[LibraryClasses]
> + BaseLib
> + DebugLib
> + MtrrLib
> +
> +[Packages]
> + MdePkg/MdePkg.dec
> + MinPlatformPkg/MinPlatformPkg.dec
> + UefiCpuPkg/UefiCpuPkg.dec
> +
> +[Sources]
> + SetCacheMtrrLib.c
> +
> +[Pcd]
> + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress
> + gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize
> +
> diff --git
> a/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrr
> Lib.c
> b/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrr
> Lib.c
> new file mode 100644
> index 000000000000..33b774fedbd3
> --- /dev/null
> +++
> b/Platform/AMD/AmdMinBoardPkg/Library/SetCacheMtrrLib/SetCacheMtrr
> Li
> +++ b.c
> @@ -0,0 +1,133 @@
> +/** @file
> +
> +SetCacheMtrr library functions.
> +This library implementation is for AMD processor based platforms.
> +
> +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights
> +reserved.<BR>
> +
> +SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <Uefi.h>
> +#include <PiPei.h>
> +#include <Library/DebugLib.h>
> +#include <Library/MtrrLib.h>
> +
> +/**
> + This function sets the cache MTRR values for PEI phase.
> +**/
> +VOID
> +EFIAPI
> +SetCacheMtrr (
> + VOID
> + )
> +{
> + EFI_STATUS Status;
> +
> + Status = MtrrSetMemoryAttribute (
> + 0,
> + 0xA0000,
> + CacheWriteBack
> + );
> + if (EFI_ERROR (Status)) {
> + DEBUG ((
> + DEBUG_ERROR,
> + "Error(%r) in setting CacheWriteBack for 0-0x9FFFF\n",
> + Status
> + ));
> + }
> +
> + Status = MtrrSetMemoryAttribute (
> + 0xA0000,
> + 0x20000,
> + CacheUncacheable
> + );
> + if (EFI_ERROR (Status)) {
> + DEBUG ((
> + DEBUG_ERROR,
> + "Error(%r) in setting CacheUncacheable for 0xA0000-0xBFFFF\n",
> + Status
> + ));
> + }
> +
> + Status = MtrrSetMemoryAttribute (
> + 0xC0000,
> + 0x40000,
> + CacheWriteProtected
> + );
> + if (EFI_ERROR (Status)) {
> + DEBUG ((
> + DEBUG_ERROR,
> + "Error(%r) in setting CacheWriteProtected for 0xC0000-0xFFFFF\n",
> + Status
> + ));
> + }
> +
> + Status = MtrrSetMemoryAttribute (
> + 0x100000,
> + 0xAFF00000,
> + CacheWriteBack
> + );
> + if (EFI_ERROR (Status)) {
> + DEBUG ((
> + DEBUG_ERROR,
> + "Error(%r) in setting CacheWriteBack for 0x100000-0xAFFFFFFF\n",
> + Status
> + ));
> + }
> +
> + Status = MtrrSetMemoryAttribute (
> + PcdGet32 (PcdFlashAreaBaseAddress),
> + PcdGet32 (PcdFlashAreaSize),
> + CacheWriteProtected
> + );
> + if (EFI_ERROR (Status)) {
> + DEBUG ((
> + DEBUG_ERROR,
> + "Error(%r) in setting CacheWriteProtected for 0x%X-0x%X\n",
> + Status,
> + PcdGet32 (PcdFlashAreaBaseAddress),
> + PcdGet32 (PcdFlashAreaBaseAddress) + PcdGet32 (PcdFlashAreaSize)
> + ));
> + }
> +
> + MtrrDebugPrintAllMtrrs ();
> + return;
> +}
> +
> +/**
> + Update MTRR setting in EndOfPei phase.
> + This function will set the MTRR value as CacheUncacheable
> + for Flash address.
> +
> + @retval EFI_SUCCESS The function completes successfully.
> + @retval Others Some error occurs.
> +**/
> +EFI_STATUS
> +EFIAPI
> +SetCacheMtrrAfterEndOfPei (
> + VOID
> + )
> +{
> + EFI_STATUS Status;
> +
> + Status = MtrrSetMemoryAttribute (
> + PcdGet32 (PcdFlashAreaBaseAddress),
> + PcdGet32 (PcdFlashAreaSize),
> + CacheUncacheable
> + );
> + if (EFI_ERROR (Status)) {
> + DEBUG ((
> + DEBUG_ERROR,
> + "Error(%r) in setting CacheUncacheable for 0x%X-0x%X\n",
> + Status,
> + PcdGet32 (PcdFlashAreaBaseAddress),
> + PcdGet32 (PcdFlashAreaBaseAddress) + PcdGet32 (PcdFlashAreaSize)
> + ));
> + }
> +
> + MtrrDebugPrintAllMtrrs ();
> + return EFI_SUCCESS;
> +}
> +
> --
> 2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102757): https://edk2.groups.io/g/devel/message/102757
Mute This Topic: https://groups.io/mt/98032730/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
