Reviewed-by: Nickle Wang <nick...@nvidia.com>
Regards,
Nickle
> -----Original Message-----
> From: Minh Nguyen <minhngu...@os.amperecomputing.com>
> Sent: Friday, April 14, 2023 4:19 PM
> To: devel@edk2.groups.io
> Cc: patc...@amperecomputing.com; abner.ch...@amd.com; Nickle Wang
> <nick...@nvidia.com>; ig...@ami.com; n...@os.amperecomputing.com;
> tinhngu...@os.amperecomputing.com; Vu Nguyen
> <vungu...@os.amperecomputing.com>; Minh Nguyen
> <minhngu...@os.amperecomputing.com>
> Subject: [PATCH 1/5] RedfishPkg: Correct variable type to prevent memory
> corruption
>
> External email: Use caution opening links or attachments
>
>
> From: Vu Nguyen <vungu...@os.amperecomputing.com>
>
> Id will be casted by CoreOpenProtocol, declare this variable with a wrong type
> might result in the corruption of other local variables.
>
> Signed-off-by: Minh Nguyen <minhngu...@os.amperecomputing.com>
> ---
> RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h
> b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h
> index 4a9e9f7b81a4..6b94e5814c43 100644
> --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h
> +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.h
> @@ -3,6 +3,7 @@
>
> Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> (C) Copyright 2020 Hewlett Packard Enterprise Development LP<BR>
> + Copyright (c) 2023, Ampere Computing LLC. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -84,7 +85,7 @@ struct _RESTEX_SERVICE {
> //
> EFI_HANDLE HttpChildHandle;
>
> - UINT32 Id;
> + UINT32 *Id;
>
> EFI_REST_EX_SERVICE_INFO RestExServiceInfo;
> };
> --
> 2.39.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102986): https://edk2.groups.io/g/devel/message/102986
Mute This Topic: https://groups.io/mt/98258309/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
