If components outside the UefiCpuPkg need access to the CpuPageTableLib, should we consider moving CpuPageTableLib to MdePkg or MdeModulePkg? There are many different boot phases that need to crate/manage page tables, so we need to find the right common location. Perhaps the only part that needs to be moved is the lib class?
Mike > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Wang, Jian J > Sent: Friday, April 14, 2023 2:03 AM > To: Tan, Dun <dun....@intel.com>; devel@edk2.groups.io > Cc: Gao, Liming <gaolim...@byosoft.com.cn>; Ni, Ray <ray...@intel.com> > Subject: Re: [edk2-devel] [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to > pass DependencyCheck > > MdeModulePkg has never depended on UefiCpuPkg before. Please double > check if there's any side effect introduced by this mutual dependency. > > Acked-by: Jian J Wang <jian.j.w...@intel.com> > > > > -----Original Message----- > > From: Tan, Dun <dun....@intel.com> > > Sent: Friday, March 31, 2023 5:34 PM > > To: devel@edk2.groups.io > > Cc: Gao, Liming <gaolim...@byosoft.com.cn>; Ni, Ray <ray...@intel.com>; > > Wang, Jian J <jian.j.w...@intel.com> > > Subject: [Patch V2 5/8] MdeModulePkg: Add UefiCpuPkg.dec to pass > > DependencyCheck > > > > Add UefiCpuPkg/UefiCpuPkg.dec in MdeModulePkg.ci.yaml to pass > > DependencyCheck since DxeIpl in MdeModulePkg needs to consume > > CpuPageTableLib in UefiCpuPkg. > > > > Signed-off-by: Dun Tan <dun....@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Jian J Wang <jian.j.w...@intel.com> > > --- > > MdeModulePkg/MdeModulePkg.ci.yaml | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml > > b/MdeModulePkg/MdeModulePkg.ci.yaml > > index f69989087b..d2616f4cdc 100644 > > --- a/MdeModulePkg/MdeModulePkg.ci.yaml > > +++ b/MdeModulePkg/MdeModulePkg.ci.yaml > > @@ -2,7 +2,7 @@ > > # CI configuration for MdeModulePkg > > # > > # Copyright (c) Microsoft Corporation > > -# Copyright (c) 2020, Intel Corporation. All rights reserved.<BR> > > +# Copyright (c) 2020 - 2023, Intel Corporation. All rights reserved.<BR> > > # (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR> > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > ## > > @@ -51,7 +51,8 @@ > > "MdePkg/MdePkg.dec", > > "MdeModulePkg/MdeModulePkg.dec", > > "StandaloneMmPkg/StandaloneMmPkg.dec", > > - "ArmPkg/ArmPkg.dec" # this should be fixed by promoting an > > abstraction > > + "ArmPkg/ArmPkg.dec", # this should be fixed by promoting an > > abstraction > > + "UefiCpuPkg/UefiCpuPkg.dec" > > ], > > # For host based unit tests > > "AcceptableDependencies-HOST_APPLICATION":[ > > -- > > 2.31.1.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103010): https://edk2.groups.io/g/devel/message/103010 Mute This Topic: https://groups.io/mt/97969862/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
