[AMD Official Use Only - General]
Hi Ray,
From open-source code I can see OVMF still implements
SmmCpuFeaturesReadSaveStateRegister.
Hence, we can't directly use SmramSaveStateReadRegister in PiSmmCpuDxe driver,
until we implement the MmSaveStateLib for Ovmf.
I think it's better to keep the code as it is, so that we will not break any
open-source or closed-source project.
Thanks
AbduL
From: Ni, Ray <ray...@intel.com>
Sent: 11 April 2023 18:19
To: Attar, AbdulLateef (Abdul Lateef) <abdullateef.at...@amd.com>;
devel@edk2.groups.io; kra...@redhat.com
Cc: Grimes, Paul <paul.gri...@amd.com>; Kirkendall, Garrett
<garrett.kirkend...@amd.com>; Chang, Abner <abner.ch...@amd.com>; Dong, Eric
<eric.d...@intel.com>; Kumar, Rahul R <rahul.r.ku...@intel.com>; Ard Biesheuvel
<ardb+tianoc...@kernel.org>; Yao, Jiewen <jiewen....@intel.com>; Justen, Jordan
L <jordan.l.jus...@intel.com>
Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib
library
[AMD Official Use Only - General]
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
yes
thanks,
ray
________________________________
From: Attar, AbdulLateef (Abdul Lateef)
<abdullateef.at...@amd.com<mailto:abdullateef.at...@amd.com>>
Sent: Tuesday, April 11, 2023 7:17:03 PM
To: Ni, Ray <ray...@intel.com<mailto:ray...@intel.com>>;
devel@edk2.groups.io<mailto:devel@edk2.groups.io>
<devel@edk2.groups.io<mailto:devel@edk2.groups.io>>;
kra...@redhat.com<mailto:kra...@redhat.com>
<kra...@redhat.com<mailto:kra...@redhat.com>>
Cc: Grimes, Paul <paul.gri...@amd.com<mailto:paul.gri...@amd.com>>; Kirkendall,
Garrett <garrett.kirkend...@amd.com<mailto:garrett.kirkend...@amd.com>>; Chang,
Abner <abner.ch...@amd.com<mailto:abner.ch...@amd.com>>; Dong, Eric
<eric.d...@intel.com<mailto:eric.d...@intel.com>>; Kumar, Rahul R
<rahul.r.ku...@intel.com<mailto:rahul.r.ku...@intel.com>>; Ard Biesheuvel
<ardb+tianoc...@kernel.org<mailto:ardb+tianoc...@kernel.org>>; Yao, Jiewen
<jiewen....@intel.com<mailto:jiewen....@intel.com>>; Justen, Jordan L
<jordan.l.jus...@intel.com<mailto:jordan.l.jus...@intel.com>>
Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib
library
[AMD Official Use Only - General]
Hi Ray,
You mean directly call the SmramSaveStateReadRegister instead of below
code from edk2/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c ?
Status = SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register, Width,
Buffer);
if (Status == EFI_UNSUPPORTED) {
Status = SmramSaveStateReadRegister (CpuIndex, Register, Width, Buffer);
}
Thanks
AbduL
-----Original Message-----
From: Ni, Ray <ray...@intel.com<mailto:ray...@intel.com>>
Sent: 11 April 2023 15:40
To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>;
kra...@redhat.com<mailto:kra...@redhat.com>; Attar, AbdulLateef (Abdul Lateef)
<abdullateef.at...@amd.com<mailto:abdullateef.at...@amd.com>>
Cc: Attar, AbdulLateef (Abdul Lateef)
<abdullateef.at...@amd.com<mailto:abdullateef.at...@amd.com>>; Grimes, Paul
<paul.gri...@amd.com<mailto:paul.gri...@amd.com>>; Kirkendall, Garrett
<garrett.kirkend...@amd.com<mailto:garrett.kirkend...@amd.com>>; Chang, Abner
<abner.ch...@amd.com<mailto:abner.ch...@amd.com>>; Dong, Eric
<eric.d...@intel.com<mailto:eric.d...@intel.com>>; Kumar, Rahul R
<rahul.r.ku...@intel.com<mailto:rahul.r.ku...@intel.com>>; Ard Biesheuvel
<ardb+tianoc...@kernel.org<mailto:ardb+tianoc...@kernel.org>>; Yao, Jiewen
<jiewen....@intel.com<mailto:jiewen....@intel.com>>; Justen, Jordan L
<jordan.l.jus...@intel.com<mailto:jordan.l.jus...@intel.com>>
Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib
library
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Gerd,
I am asking Abdul to directly call SaveStateLib from CpuSmm driver.
I don't think SmmCpuFeaturesLib should be in the middle of CpuSmm driver and
SaveStateLib regarding the save state access.
Thanks,
Ray
> -----Original Message-----
> From: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Gerd
> Hoffmann
> Sent: Tuesday, April 11, 2023 5:43 PM
> To: Abdul Lateef Attar <abdat...@amd.com<mailto:abdat...@amd.com>>
> Cc: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Abdul Lateef Attar
> <abdullateef.at...@amd.com<mailto:abdullateef.at...@amd.com>>; Paul Grimes
> <paul.gri...@amd.com<mailto:paul.gri...@amd.com>>;
> Garrett Kirkendall
> <garrett.kirkend...@amd.com<mailto:garrett.kirkend...@amd.com>>; Abner Chang
> <abner.ch...@amd.com<mailto:abner.ch...@amd.com>>; Dong, Eric
> <eric.d...@intel.com<mailto:eric.d...@intel.com>>; Ni, Ray
> <ray...@intel.com<mailto:ray...@intel.com>>; Kumar, Rahul R
> <rahul.r.ku...@intel.com<mailto:rahul.r.ku...@intel.com>>; Ard
> Biesheuvel <ardb+tianoc...@kernel.org<mailto:ardb+tianoc...@kernel.org>>;
> Yao, Jiewen
> <jiewen....@intel.com<mailto:jiewen....@intel.com>>; Justen, Jordan L
> <jordan.l.jus...@intel.com<mailto:jordan.l.jus...@intel.com>>
> Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses
> SmmSmramSaveStateLib library
>
> > Uses new SmmSmramSaveStateLib library, which fix the CI failure.
>
> What is the exact failure you are seeing?
>
> > +
> SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Intel
> SmmSmramSaveStateLib.inf
>
> This should be the AMD version. KVM uses the AMD smram state.
>
> Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use
> actually use the new SmmSmramSaveStateLib library, and once this has
> been done it should be possible to remove
> OvmfPkg/Include/Register/QemuSmramSaveStateMap.h
>
> take care,
> Gerd
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103179): https://edk2.groups.io/g/devel/message/103179
Mute This Topic: https://groups.io/mt/98172964/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
