[AMD Official Use Only - General]
Hi all,
I had pushed this patch set to edk2-platforms. Although not all of the
maintainers/reviewers gave R-b for each patch, we got at least one R-b for
each. Just let me know if you have further comments.
NV and Ampere will move forward to help implementing OpenBMC IPMI BLOB transfer
and also support SSIF as a transport interface for IPMI.
Thanks
Abner
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> Abner via groups.io
> Sent: Friday, April 21, 2023 1:23 PM
> To: devel@edk2.groups.io
> Cc: Isaac Oram <isaac.w.o...@intel.com>; Attar, AbdulLateef (Abdul Lateef)
> <abdullateef.at...@amd.com>; Nickle Wang <nick...@nvidia.com>; Igor
> Kulchytskyy <ig...@ami.com>; Tinh Nguyen
> <tinhngu...@os.amperecomputing.com>
> Subject: [edk2-devel] [edk2-platforms][PATCH V3 00/14] ManageabilityPkg
> part II
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> From: Abner Chang <abner.ch...@amd.com>
>
> In V3: Address comments given to V2.
>
> In V2:
> - Address uncrustify issues.
> - Use DBBUG_MANAGEABILITY_INFO to output detailed
> manageability information.
> DEBUG_INFO is used for the function entry point,
> while DEBUG_ERROR is used for the error situations.
>
> In part II, we had implemented
> - PLDM protocol
> - MCTP protocol
> - PLDM SMBIOS Transfer protocol
> - MCTP manageability transport interface
> - Support maximum transfer unit of transport interface
> - Add more heler functions
> - Add two new fields HeaderSize and TrailerSize in
> MANAGEABILITY_TRANSFER_TOKEN structure.
> - Add PCDs to build the manageability modules.
>
> Signed-off-by: Abner Chang <abner.ch...@amd.com>
> Cc: Isaac Oram <isaac.w.o...@intel.com>
> Cc: Abdul Lateef Attar <abdat...@amd.com>
> Cc: Nickle Wang <nick...@nvidia.com>
> Cc: Igor Kulchytskyy <ig...@ami.com>
> Cc: Tinh Nguyen <tinhngu...@os.amperecomputing.com>
>
> Abner Chang (14):
> ManageabilityPkg: Add more helper functions
> ManageabilityPkg: Support Maximum Transfer Unit
> ManageabilityPkg: Add HeaderSize and TrailerSize
> ManageabilityPkg: Add PldmProtocolLib
> ManageabilityPkg: Add PldmSmbiosTransferDxe driver
> ManageabilityPkg/KCS: KCS transport interface
> ManageabilityPkg: Add definitions of MCTP
> ManageabilityPkg: Add MCTP manageability header file
> ManageabilityPkg/MctpProtocol: Add MctpProtocol
> ManageabilityPkg: Add MCTP transport interface
> ManageabilityPkg/PldmProtocol: Add PLDM protocol
> ManageabilityPkg: Add Manageability PCDs
> ManageabilityPkg: Relocate Manageability.dsc
> ManageabilityPkg: Add Manageability FDFs
>
> .../ManageabilityPkg/ManageabilityPkg.dec | 28 +
> .../Include/{Dsc => }/Manageability.dsc | 20 +
> .../ManageabilityPkg/ManageabilityPkg.dsc | 14 +-
> .../ManageabilityPkg/Include/PostMemory.fdf | 28 +
> .../ManageabilityPkg/Include/PreMemory.fdf | 12 +
> .../BaseManageabilityTransportHelper.inf | 1 +
> .../Dxe/DxeManageabilityTransportMctp.inf | 44 ++
> .../Dxe/PldmProtocolLib.inf | 42 ++
> .../MctpProtocol/Dxe/MctpProtocolDxe.inf | 53 ++
> .../PldmProtocol/Dxe/PldmProtocolDxe.inf | 50 ++
> .../PldmSmbiosTransferDxe.inf | 47 ++
> .../Include/Library/BasePldmProtocolLib.h | 41 ++
> .../Library/ManageabilityTransportHelperLib.h | 97 ++++
> .../Library/ManageabilityTransportLib.h | 35 +-
> .../Library/ManageabilityTransportMctpLib.h | 54 ++
> .../Include/Protocol/MctpProtocol.h | 102 ++++
> .../Include/Protocol/PldmProtocol.h | 87 +++
> .../Protocol/PldmSmbiosTransferProtocol.h | 184 ++++++
> .../Common/ManageabilityTransportKcs.h | 22 +-
> .../Dxe/ManageabilityTransportMctp.h | 26 +
> .../IpmiProtocol/Common/IpmiProtocolCommon.h | 36 +-
> .../IpmiProtocol/Pei/IpmiPpiInternal.h | 8 +-
> .../MctpProtocol/Common/MctpProtocolCommon.h | 139
> +++++ .../PldmProtocol/Common/PldmProtocolCommon.h | 109 ++++
> .../BaseManageabilityTransportHelper.c | 225 +++++++-
> .../BaseManageabilityTransportNull.c | 18 +-
> .../Common/KcsCommon.c | 208 ++++---
> .../Dxe/ManageabilityTransportKcs.c | 89 +--
> .../Dxe/ManageabilityTransportMctp.c | 367 ++++++++++++
> .../PldmProtocolLibrary/Dxe/PldmProtocolLib.c | 87
> +++ .../IpmiProtocol/Common/IpmiProtocolCommon.c | 63 ++-
> .../Universal/IpmiProtocol/Dxe/IpmiProtocol.c | 24 +-
> .../Universal/IpmiProtocol/Pei/IpmiPpi.c | 51 +-
> .../Universal/IpmiProtocol/Smm/IpmiProtocol.c | 24 +-
> .../MctpProtocol/Common/MctpProtocolCommon.c | 472
> ++++++++++++++++ .../Universal/MctpProtocol/Dxe/MctpProtocol.c | 218
> ++++++++ .../PldmProtocol/Common/PldmProtocolCommon.c | 437
> +++++++++++++++ .../Universal/PldmProtocol/Dxe/PldmProtocol.c | 181
> ++++++
> .../PldmSmbiosTransferDxe.c | 525 ++++++++++++++++++
> Features/ManageabilityPkg/Readme.md | 10 +
> .../Dxe/ManageabilityTransportMctp.uni | 13 +
> .../Dxe/PldmProtocolLib.uni | 18 +
> 42 files changed, 4095 insertions(+), 214 deletions(-) rename
> Features/ManageabilityPkg/Include/{Dsc => }/Manageability.dsc (57%)
> create mode 100644 Features/ManageabilityPkg/Include/PostMemory.fdf
> create mode 100644 Features/ManageabilityPkg/Include/PreMemory.fdf
> create mode 100644
> Features/ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/Dx
> eManageabilityTransportMctp.inf
> create mode 100644
> Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtocolL
> ib.inf
> create mode 100644
> Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.i
> nf
> create mode 100644
> Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocolDxe.i
> nf
> create mode 100644
> Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbios
> TransferDxe.inf
> create mode 100644
> Features/ManageabilityPkg/Include/Library/BasePldmProtocolLib.h
> create mode 100644
> Features/ManageabilityPkg/Include/Library/ManageabilityTransportMctpLib.
> h
> create mode 100644
> Features/ManageabilityPkg/Include/Protocol/MctpProtocol.h
> create mode 100644
> Features/ManageabilityPkg/Include/Protocol/PldmProtocol.h
> create mode 100644
> Features/ManageabilityPkg/Include/Protocol/PldmSmbiosTransferProtocol.
> h
> create mode 100644
> Features/ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/M
> anageabilityTransportMctp.h
> create mode 100644
> Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtoco
> lCommon.h
> create mode 100644
> Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocol
> Common.h
> create mode 100644
> Features/ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/M
> anageabilityTransportMctp.c
> create mode 100644
> Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtocolL
> ib.c
> create mode 100644
> Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtoco
> lCommon.c
> create mode 100644
> Features/ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocol.c
> create mode 100644
> Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocol
> Common.c
> create mode 100644
> Features/ManageabilityPkg/Universal/PldmProtocol/Dxe/PldmProtocol.c
> create mode 100644
> Features/ManageabilityPkg/Universal/PldmSmbiosTransferDxe/PldmSmbios
> TransferDxe.c
> create mode 100644
> Features/ManageabilityPkg/Library/ManageabilityTransportMctpLib/Dxe/M
> anageabilityTransportMctp.uni
> create mode 100644
> Features/ManageabilityPkg/Library/PldmProtocolLibrary/Dxe/PldmProtocolL
> ib.uni
>
> --
> 2.37.1.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103505): https://edk2.groups.io/g/devel/message/103505
Mute This Topic: https://groups.io/mt/98404944/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
