Reviewed-by: Jiewen Yao <[email protected]> > -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of Gerd > Hoffmann > Sent: Thursday, April 27, 2023 12:24 AM > To: [email protected] > Cc: Wang, Jian J <[email protected]>; Pawel Polawski > <[email protected]>; Oliver Steffen <[email protected]>; Yao, > Jiewen <[email protected]>; Gerd Hoffmann <[email protected]> > Subject: [edk2-devel] [PATCH 1/2] SecurityPkg: add TIS sanity check (tpm2) > > The code blindly assumes a TIS interface is present in case both CRB and > FIFO checks fail. Check the InterfaceType for TIS instead and only > return Tpm2PtpInterfaceTis in case it matches, Tpm2PtpInterfaceMax > otherwise. > > Signed-off-by: Gerd Hoffmann <[email protected]> > --- > SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > index 1f9ac5ab5a30..eac9f0e29941 100644 > --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c > @@ -464,7 +464,11 @@ Tpm2GetPtpInterface ( > return Tpm2PtpInterfaceFifo; > } > > - return Tpm2PtpInterfaceTis; > + if (InterfaceId.Bits.InterfaceType == > PTP_INTERFACE_IDENTIFIER_INTERFACE_TYPE_TIS) { > + return Tpm2PtpInterfaceTis; > + } > + > + return Tpm2PtpInterfaceMax; > } > > /** > -- > 2.40.0 > > > > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103716): https://edk2.groups.io/g/devel/message/103716 Mute This Topic: https://groups.io/mt/98518597/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
