Thanks for @K N, Karthik<mailto:karthik....@intel.com> and @Prakashan, Krishnadas Veliyathuparambil<mailto:krishnadas.veliyathuparambil.prakas...@intel.com> help to review it from your side.
Hi Mike Do we have any stakeholder from Edk2 side also need to them to review it before checking the source code ? I can also cc them into the mail loop. Thanks, Gua From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guo, Gua Sent: Monday, April 24, 2023 9:38 AM To: devel@edk2.groups.io; Guo, Gua <gua....@intel.com>; Hsu, VictorX <victorx....@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakas...@intel.com>; K N, Karthik <karthik....@intel.com>; Chan, Laura <laura.c...@intel.com> Cc: Chiu, Chasel <chasel.c...@intel.com>; Lu, James <james...@intel.com> Subject: Re: [edk2-devel] [PATCH 0/4] Trace Hub debug library support @Kinney, Michael D<mailto:michael.d.kin...@intel.com>, @K N, Karthik<mailto:karthik....@intel.com>, @Prakashan, Krishnadas Veliyathuparambil<mailto:krishnadas.veliyathuparambil.prakas...@intel.com>, @Chan, Laura<mailto:laura.c...@intel.com> Could you share me about your concern ? If no additional concern, please help to give your review-by we can check in ASAP. Thanks, Gua -----Original Message----- From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of Guo, Gua Sent: Friday, April 21, 2023 10:33 AM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io>; Hsu, VictorX <victorx....@intel.com<mailto:victorx....@intel.com>> Cc: Chiu, Chasel <chasel.c...@intel.com<mailto:chasel.c...@intel.com>>; Kinney, Michael D <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; Prakashan, Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakas...@intel.com<mailto:krishnadas.veliyathuparambil.prakas...@intel.com>>; K N, Karthik <karthik....@intel.com<mailto:karthik....@intel.com>>; Chan, Laura <laura.c...@intel.com<mailto:laura.c...@intel.com>> Subject: Re: [edk2-devel] [PATCH 0/4] Trace Hub debug library support + Related folk I want to let the PR for related stakeholder review it. And have any open ? https://github.com/tianocore/edk2/pull/3901 Thanks, Gua -----Original Message----- From: devel@edk2.groups.io<mailto:devel@edk2.groups.io> <devel@edk2.groups.io<mailto:devel@edk2.groups.io>> On Behalf Of victorx....@intel.com<mailto:victorx....@intel.com> Sent: Tuesday, April 18, 2023 7:05 PM To: devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Hsu, VictorX <victorx....@intel.com<mailto:victorx....@intel.com>> Subject: [edk2-devel] [PATCH 0/4] Trace Hub debug library support From: VictorX Hsu <victorx....@intel.com<mailto:victorx....@intel.com>> - TraceHub UniversalPayload Spec: https://github.com/UniversalScalableFirmware/documentation/pull/52 (Industry Standard) - MipiSysTLib Wrapper: https://github.com/MIPI-Alliance/public-mipi-sys-t.git (Industry Standard) - TraceHubDebugLib: Intel(R) Trace Hub (TH) — The Linux Kernel documentation (Industry Standard) Developers Guide: https://cdrdv2-public.intel.com/671536/intel-trace-hub-developers-manual-2-1-2.pdf (Public Document) VictorX Hsu (4): MdePkg: Add MipiSysTLib library MdeModulePkg: Add TraceHubDebugSysTLib library MdePkg: Add NULL library of TraceHubDebugSysTLib Maintainers.txt: Update reviewers and maintainers for Trace Hub dbg lib. .gitmodules | 5 +- .pytool/CISettings.py | 2 + Maintainers.txt | 18 + .../Include/Guid/TraceHubDebugInfoHob.h | 25 + .../BaseTraceHubDebugSysTLib.c | 251 ++++++ .../BaseTraceHubDebugSysTLib.inf | 44 + .../DxeSmmTraceHubDebugSysTLib.c | 247 ++++++ .../DxeSmmTraceHubDebugSysTLib.inf | 50 ++ .../InternalTraceHubApi.c | 82 ++ .../InternalTraceHubApi.h | 46 + .../InternalTraceHubApiCommon.c | 208 +++++ .../InternalTraceHubApiCommon.h | 119 +++ .../PeiTraceHubDebugSysTLib.c | 290 +++++++ .../PeiTraceHubDebugSysTLib.inf | 50 ++ .../Library/TraceHubDebugSysTLib/Readme.md | 30 + MdeModulePkg/MdeModulePkg.dec | 21 + MdeModulePkg/MdeModulePkg.dsc | 3 + MdeModulePkg/MdeModulePkg.uni | 18 + MdePkg/Include/Library/MipiSysTLib.h | 66 ++ MdePkg/Include/Library/TraceHubDebugSysTLib.h | 81 ++ MdePkg/Library/MipiSysTLib/GenMipiSystH.py | 132 +++ MdePkg/Library/MipiSysTLib/MipiSysTLib.c | 123 +++ MdePkg/Library/MipiSysTLib/MipiSysTLib.inf | 55 ++ MdePkg/Library/MipiSysTLib/Platform.c | 164 ++++ MdePkg/Library/MipiSysTLib/Platform.h | 138 +++ MdePkg/Library/MipiSysTLib/Readme.md | 25 + MdePkg/Library/MipiSysTLib/mipi_syst.h | 789 ++++++++++++++++++ MdePkg/Library/MipiSysTLib/mipisyst | 1 + .../TraceHubDebugSysTLibNull.c | 76 ++ .../TraceHubDebugSysTLibNull.inf | 29 + MdePkg/MdePkg.ci.yaml | 15 +- MdePkg/MdePkg.dec | 9 + MdePkg/MdePkg.dsc | 2 + ReadMe.rst | 1 + 34 files changed, 3212 insertions(+), 3 deletions(-) create mode 100644 MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.inf create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTLib.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTLib.inf create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.h create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.h create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.c create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.inf create mode 100644 MdeModulePkg/Library/TraceHubDebugSysTLib/Readme.md create mode 100644 MdePkg/Include/Library/MipiSysTLib.h create mode 100644 MdePkg/Include/Library/TraceHubDebugSysTLib.h create mode 100644 MdePkg/Library/MipiSysTLib/GenMipiSystH.py create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.c create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.inf create mode 100644 MdePkg/Library/MipiSysTLib/Platform.c create mode 100644 MdePkg/Library/MipiSysTLib/Platform.h create mode 100644 MdePkg/Library/MipiSysTLib/Readme.md create mode 100644 MdePkg/Library/MipiSysTLib/mipi_syst.h create mode 160000 MdePkg/Library/MipiSysTLib/mipisyst create mode 100644 MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.c create mode 100644 MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.inf -- 2.40.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#103921): https://edk2.groups.io/g/devel/message/103921 Mute This Topic: https://groups.io/mt/98351445/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
