Hello Andrew Fish,
Sorry that we seem to miss you from previous patch CC list mistakenly, please help to review this series about new submodule we are adding and let us know if any feedbacks. Thanks, Chasel > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Guo, Gua > Sent: Wednesday, May 10, 2023 4:39 PM > To: devel@edk2.groups.io > Cc: Guo, Gua <gua....@intel.com> > Subject: [edk2-devel] [PATCH v9 0/5] Trace Hub debug library support > > From: Gua Guo <gua....@intel.com> > > V9: Add more maintainers into CC list > - https://github.com/tianocore/edk2/pull/3901 > F: * > M: Andrew Fish <af...@apple.com> [ajfish] > M: Leif Lindholm <quic_llind...@quicinc.com> [leiflindholm] > M: Michael D Kinney <michael.d.kin...@intel.com> [mdkinney] > > MdeModulePkg > M: Jian J Wang <jian.j.w...@intel.com> [jwang36] > M: Liming Gao <gaolim...@byosoft.com.cn> [lgao4] > > .pytool/ > M: Sean Brogan <sean.bro...@microsoft.com> [spbrogan] > M: Michael Kubacki <mikub...@linux.microsoft.com> [makubacki] > R: Michael D Kinney <michael.d.kin...@intel.com> [mdkinney] > R: Liming Gao <gaolim...@byosoft.com.cn> [lgao4] > > MdePkg/ > M: Michael D Kinney <michael.d.kin...@intel.com> [mdkinney] > M: Liming Gao <gaolim...@byosoft.com.cn> [lgao4] > R: Zhiguang Liu <zhiguang....@intel.com> [LiuZhiguang001] > > > V8: Add MdeModulePkg maintainers into CC list > > V7: Miss one patch on V6 > > V6: > - https://github.com/tianocore/edk2/pull/3901 > Split submodule into new patch > Fix formatting issue > Add Review-by message > Offline check with Victor to use my sign-off name. > > V5: if no other open, it will be final change > - https://github.com/tianocore/edk2/pull/3901 > Fix random exception when long run catalog debug message > > V4 > - https://github.com/tianocore/edk2/pull/3901 - Done > Enhance SwapBytesGuid to use CopyGuid instead of CopyMem, to make > implement code more simple. > > V3 > - https://github.com/tianocore/edk2/pull/3901 - Done > - Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why > MAX_TRACE_HUB_DEBUG_INSTANCE hardcoded to 5? > Solution: Remove this macro, use Library Constructor to allocate it > dynamiclly. > - Open: > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.c: > SwapBytesGuid () algorithm wrong. > Solution: Follow correct algorithm to implement it. > VOID > EFIAPI > SwapBytesGuid ( > IN GUID *Guid, <----------- In PreMem, guid is global data > so region is > readonly, add output data to support it. > OUT GUID *ConvertedGuid > ); > > - Open: Merge MSFT and GCC CC_FLAGS as they both supports -D > Solution: use *_*_*_CC_FLAGS = -DMIPI_SYST_STATIC to unified both. > > > V2 > - https://github.com/tianocore/edk2/pull/3901 > - Open: MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h: why > MAX_TRACE_HUB_DEBUG_INSTANCE hardcoded to 5? > - Open: > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.c: > SwapBytesGuid () algorithm wrong. > - Open: Merge MSFT and GCC CC_FLAGS as they both supports -D > > V1 > Previous PR: > - https://github.com/tianocore/edk2/pull/3613 > - TraceHubDebugLib without submodule - Reject > > - https://github.com/tianocore/edk2/pull/3793 > - TraceHubDebugLib with submodule and without seperate into MipiSysTLib > and TraceHubDebugLib - Reject > > Gua Guo (5): > MdePkg: Add mipisyst submodule > MdePkg: Add MipiSysTLib library > MdePkg: Add NULL library of TraceHubDebugSysTLib > MdeModulePkg: Add TraceHubDebugSysTLib library > Maintainers.txt: Update reviewers and maintainers for > TraceHubDebugLib. > > .gitmodules | 3 + > .pytool/CISettings.py | 2 + > Maintainers.txt | 18 + > .../Include/Guid/TraceHubDebugInfoHob.h | 24 + > .../BaseTraceHubDebugSysTLib.c | 245 ++++++ > .../BaseTraceHubDebugSysTLib.inf | 44 + > .../DxeSmmTraceHubDebugSysTLib.c | 263 ++++++ > .../DxeSmmTraceHubDebugSysTLib.inf | 51 ++ > .../InternalTraceHubApi.c | 74 ++ > .../InternalTraceHubApi.h | 37 + > .../InternalTraceHubApiCommon.c | 200 +++++ > .../InternalTraceHubApiCommon.h | 119 +++ > .../PeiTraceHubDebugSysTLib.c | 282 +++++++ > .../PeiTraceHubDebugSysTLib.inf | 50 ++ > .../Library/TraceHubDebugSysTLib/Readme.md | 26 + > MdeModulePkg/MdeModulePkg.dec | 21 + > MdeModulePkg/MdeModulePkg.dsc | 3 + > MdeModulePkg/MdeModulePkg.uni | 18 + > MdePkg/Include/Library/MipiSysTLib.h | 66 ++ > MdePkg/Include/Library/TraceHubDebugSysTLib.h | 81 ++ > MdePkg/Library/MipiSysTLib/GenMipiSystH.py | 132 +++ > MdePkg/Library/MipiSysTLib/MipiSysTLib.c | 123 +++ > MdePkg/Library/MipiSysTLib/MipiSysTLib.inf | 52 ++ > MdePkg/Library/MipiSysTLib/Platform.c | 164 ++++ > MdePkg/Library/MipiSysTLib/Platform.h | 138 +++ > MdePkg/Library/MipiSysTLib/Readme.md | 25 + > MdePkg/Library/MipiSysTLib/mipi_syst.h | 789 ++++++++++++++++++ > MdePkg/Library/MipiSysTLib/mipisyst | 1 + > .../TraceHubDebugSysTLibNull.c | 76 ++ > .../TraceHubDebugSysTLibNull.inf | 29 + > MdePkg/MdePkg.ci.yaml | 12 +- > MdePkg/MdePkg.dec | 9 + > MdePkg/MdePkg.dsc | 2 + > ReadMe.rst | 1 + > 34 files changed, 3177 insertions(+), 3 deletions(-) create mode 100644 > MdeModulePkg/Include/Guid/TraceHubDebugInfoHob.h > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/BaseTraceHubDebugSysTLib.inf > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTLi > b.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/DxeSmmTraceHubDebugSysTLi > b.inf > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApi.h > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/InternalTraceHubApiCommon.h > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.c > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/PeiTraceHubDebugSysTLib.inf > create mode 100644 > MdeModulePkg/Library/TraceHubDebugSysTLib/Readme.md > create mode 100644 MdePkg/Include/Library/MipiSysTLib.h > create mode 100644 MdePkg/Include/Library/TraceHubDebugSysTLib.h > create mode 100644 MdePkg/Library/MipiSysTLib/GenMipiSystH.py > create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.c > create mode 100644 MdePkg/Library/MipiSysTLib/MipiSysTLib.inf > create mode 100644 MdePkg/Library/MipiSysTLib/Platform.c > create mode 100644 MdePkg/Library/MipiSysTLib/Platform.h > create mode 100644 MdePkg/Library/MipiSysTLib/Readme.md > create mode 100644 MdePkg/Library/MipiSysTLib/mipi_syst.h > create mode 160000 MdePkg/Library/MipiSysTLib/mipisyst > create mode 100644 > MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.c > create mode 100644 > MdePkg/Library/TraceHubDebugSysTLibNull/TraceHubDebugSysTLibNull.inf > > -- > 2.39.2.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#104658): https://edk2.groups.io/g/devel/message/104658 Mute This Topic: https://groups.io/mt/98817579/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
