On 5/24/23 11:11, Gerd Hoffmann wrote: > Not needed any more, SMM + 64-bit PEI + S3 suspend works now. While > being at it also remove it from Bhyve (where it is dead code). > > Fixed by commits: > - 8bd2028f9ac3 ("MdeModulePkg: Supporting S3 in 64bit PEI") > - 6acf72901a2e ("UefiCpuPkg: Supporting S3 in 64bit PEI") > See also https://bugzilla.tianocore.org/show_bug.cgi?id=4195 > > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > Reviewed-by: Ard Biesheuvel <a...@kernel.org> > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > Reviewed-by: Ray Ni <ray...@intel.com> > --- > OvmfPkg/Bhyve/PlatformPei/Platform.c | 29 -------------------------- > OvmfPkg/PlatformPei/Platform.c | 31 ---------------------------- > 2 files changed, 60 deletions(-)
I disagree with this (v2) update. Bhyve platform code and QEMU platform code should not be fused into a common patch, if there's a way to avoid that. The reviewers for these C files are also different. If we want to modify Bhyve as a courtesy, we can certainly propose a *separate* patch for that. If others approve this patch, I can't block it from going in; since I've been CC'd (and I thought I'd comment this time), this is my view on it. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105228): https://edk2.groups.io/g/devel/message/105228 Mute This Topic: https://groups.io/mt/99104839/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-