On Thu, 1 Jun 2023 at 19:12, Pedro Falcato <pedro.falc...@gmail.com> wrote: > > On Thu, Jun 1, 2023 at 5:12 PM Ard Biesheuvel <a...@kernel.org> wrote: > > > > On Tue, 9 May 2023 at 18:32, Pedro Falcato <pedro.falc...@gmail.com> wrote: > > > > > > This patch-set replaces the OVMF specific SataControllerDxe with the > > > MdeModulePkg/Bus/Pci one. > > > They were both forked from the same code, and are code-and-functionality > > > similar. As such, there > > > seems to be no need for duplication here. > > > > > > The first four pages both replay OvmfPkg/SataControllerDxe commits and > > > fix up a couple of details. > > > The rest of the patches (minus the last) replace > > > OvmfPkg/SataControllerDxe with the MdeModulePkg variant. > > > The last patch, finally, removes the thing. > > > > > > Tested by booting in QEMU (Q35 (AHCI) and PC (IDE)). > > > More testing from other, alternative platforms is desired, although > > > breakage seems unlikely. > > > > > > This patchset (or at least, the last patch) depends on the edk2-platforms > > > patch series to get merged. > > > > > > (+CC Laszlo as the author of the original SataControllerDxe patches) > > > > > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > > Cc: Jiewen Yao <jiewen....@intel.com> > > > Cc :Jordan Justen <jordan.l.jus...@intel.com> > > > Cc: Gerd Hoffmann <kra...@redhat.com> > > > Cc: Erdem Aktas <erdemak...@google.com> > > > Cc: James Bottomley <j...@linux.ibm.com> > > > Cc: Min Xu <min.m...@intel.com> > > > Cc: Tom Lendacky <thomas.lenda...@amd.com> > > > Cc: Michael Roth <michael.r...@amd.com> > > > Cc: Rebecca Cran <rebe...@bsdio.com> > > > Cc: Peter Grehan <gre...@freebsd.org> > > > Cc: Corvin Köhne <corv...@freebsd.org> > > > Cc: Sebastien Boeuf <sebastien.bo...@intel.com> > > > Cc: Anthony Perard <anthony.per...@citrix.com> > > > Cc: Julien Grall <jul...@xen.org> > > > Cc: Laszlo Ersek <ler...@redhat.com> > > > > > > Changes: > > > v2: > > > - Address Laszlo's feedback wrt commit to port into MdeModulePkg > > > - Address Laszlo's feedback wrt how to split the removal of the driver > > > and the patches for each sub-platform maintainer > > > - Address Mike Maslenkin's feedback on the preexisting ASSERTs (Private > > > != NULL) > > > - Add Gerd's ACK and Tested-by (conservatively) to patches 6 and 12 > > > (since they are remotely QEMU related) > > > > > > Pedro Falcato (12): > > > MdeModulePkg/SataControllerDxe: Clean up error handling in Start() > > > MdeModulePkg/SataControllerDxe: Log expected errors at DEBUG_INFO > > > level > > > MdeModulePkg/SataControllerDxe: Remove useless null check > > > MdeModulePkg/SataControllerDxe: Fix up ASSERTS (Private != NULL) > > > OvmfPkg: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg/Microvm: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg/Bhyve: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg/CloudHv: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg/IntelTdx: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg/AmdSev: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg/Xen: Replace the OVMF-specific SataControllerDxe > > > OvmfPkg: Remove SataControllerDxe > > > > > > > What is the state of this series? > > > > Are we waiting for the MdeModulePkg changes to be picked up, and do > > the OVMF changes have to wait for that? > > Hi Ard, > > I believe we've got the appropriate reviews/acks from the relevant > people for both MdeModulePkg and OvmfPkg. > > I've just updated my PR with the appropriate tags on each commit: > https://github.com/tianocore/edk2/pull/4370 >
In that case, please send it out again, and I'll go and merge it. Thanks, -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#105579): https://edk2.groups.io/g/devel/message/105579 Mute This Topic: https://groups.io/mt/98787852/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
