Thanks.

Please help to:
* Update the DSC file in the last commit (patch 3/3 of the series). Patch 1/3 
only adds NetworkCommon & UsbRndis, this will cause build failure in certain 
scenario.
* Add the Bugzilla link information in the commit log message.

With above handled:
Acked-by: Hao A Wu <hao.a...@intel.com>

Also sorry for a question:
  MdeModulePkg/Bus/Usb/UsbNetwork/NetworkCommon/NetworkCommon.inf
  MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcEcm/UsbCdcEcm.inf
  MdeModulePkg/Bus/Usb/UsbNetwork/UsbCdcNcm/UsbCdcNcm.inf
  MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis/UsbRndis.inf
These drivers follow the UEFI Driver Model (install EFI Driver Binding 
Protocol), why they are listed as DXE_DRIVER instead of UEFI_DRIVER in the INF 
files?

Best Regards,
Hao Wu

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> RichardHo [何明忠] via groups.io
> Sent: Thursday, June 8, 2023 11:48 AM
> To: Wu, Hao A <hao.a...@intel.com>; devel@edk2.groups.io
> Cc: Andrew Fish <af...@apple.com>; Leif Lindholm
> <quic_llind...@quicinc.com>; Kinney, Michael D
> <michael.d.kin...@intel.com>; Michael Kubacki
> <mikub...@linux.microsoft.com>; Liu, Zhiguang <zhiguang....@intel.com>;
> Gao, Liming <gaolim...@byosoft.com.cn>; Ni, Ray <ray...@intel.com>; Tinh
> Nguyen <tinhngu...@os.amperecomputing.com>; Rebecca Cran
> <rebe...@bsdio.com>; Tony Lo (�_金松) <ton...@ami.com>
> Subject: Re: [edk2-devel] [PATCH v3 1/3]
> MdeModulePkg/Bus/Usb/UsbNetwork/UsbRndis: Add USB RNDIS devices
> support
> 
> Hi Hao Wu,
> 
> I have created it in 2023-05-07.
> https://bugzilla.tianocore.org/show_bug.cgi?id=4451
> 
> Thanks,
> Richard


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105916): https://edk2.groups.io/g/devel/message/105916
Mute This Topic: https://groups.io/mt/99398816/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to