Looks good to me. Minor nit: is that really a %d (signed) and not a %u?
Reviewed-by: Andrei Warkentin <andrei.warken...@intel.com> > -----Original Message----- > From: Sunil V L <suni...@ventanamicro.com> > Sent: Monday, July 17, 2023 11:59 AM > To: devel@edk2.groups.io > Cc: Sunil V L <suni...@ventanamicro.com>; Ard Biesheuvel > <ardb+tianoc...@kernel.org>; Yao, Jiewen <jiewen....@intel.com>; Justen, > Jordan L <jordan.l.jus...@intel.com>; Gerd Hoffmann <kra...@redhat.com>; > Warkentin, Andrei <andrei.warken...@intel.com> > Subject: [PATCH 1/1] OvmfPkg/RiscVVirt: Avoid printing hard coded timeout > value > > Print the timeout value set in the PCD variable instead of hard coded 10 > seconds. > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > Cc: Andrei Warkentin <andrei.warken...@intel.com> > > Signed-off-by: Sunil V L <suni...@ventanamicro.com> > --- > OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c > b/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c > index be4316f320f9..964c35ee5328 100644 > --- a/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/OvmfPkg/RiscVVirt/Library/PlatformBootManagerLib/PlatformBm.c > @@ -936,7 +936,7 @@ PlatformBootManagerAfterConsole ( > ); > } > > - Print (L"Press ESCAPE within 10 seconds for boot options "); > + Print (L"Press ESCAPE within %d seconds for boot options ", PcdGet16 > + (PcdPlatformBootTimeOut)); > // > // Process QEMU's -kernel command line option. The kernel booted this way > // will receive ACPI tables: in PlatformBootManagerBeforeConsole(), we > -- > 2.39.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106972): https://edk2.groups.io/g/devel/message/106972 Mute This Topic: https://groups.io/mt/100198952/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
