Hi Likun,
Liming and Hao have reviewd and acked your patch, I think you can submit
your patch on edk2 repo and don't forget include Liming and Hao review
message. Good job!
Thanks,
Chao
在 2023/7/27 11:21, 苏丽坤 写道:
Hi, Hao,Liming,
this is my reply， function XhcInitializeDeviceSlot64 will init
EndpointTransferRing,while fuctionUsbMassReadBlocks return (Invalid
Parameter), which result in run function UsbMassReset, this will call
XhcDisableSlotCmd64, will clear EndpointTransferRing, like
this Xhc->UsbDevContext[SlotId].EndpointTransferRing[Index] = NULL;
If fuctionUsbMassReadBlocks return success also run function
UsbMassReset, will hang for the same reason. why
fuctionUsbMassReadBlocks return (Invalid Parameter), this function
will call UsbBootRequestSense,this retun (Invalid Parameter). At the
same time, Ehcialsoretun (Invalid Parameter).
Thanks
-----原始邮件-----
*发件人:* "Wu, Hao A" <hao.a...@intel.com>
*发送时间:* 2023-07-25 10:18:42 (星期二)
*收件人:* "Gao, Liming" <gaolim...@byosoft.com.cn>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"suli...@loongson.cn" <suli...@loongson.cn>, "Demeter, Miki"
<miki.deme...@intel.com>
*主题:* RE: [edk2-devel] empty USB DVD disk hang Xhci
Sorry, I do not have much resource to review this in detail. But
the patch generally looks good to me:
Acked-by: Hao A Wu hao.a...@intel.com
However, I hope the below question can be answered (or add related
information to the commit log message) before mering:
Likun, could you help to elaborate a bit more on why the below
statement will return NULL pointer for “USB DVD with empty disk”?
EPRing = (TRANSFER_RING
*)(UINTN)Xhc->UsbDevContext[SlotId].EndpointTransferRing[Dci-1];
Best Regards,
Hao Wu
*From:*gaoliming <gaolim...@byosoft.com.cn>
*Sent:* Tuesday, July 25, 2023 9:44 AM
*To:* devel@edk2.groups.io; suli...@loongson.cn; Demeter, Miki
<miki.deme...@intel.com>
*Cc:* Wu, Hao A <hao.a...@intel.com>
*Subject:* 回复: [edk2-devel] empty USB DVD disk hang Xhci
Likun:
This change is good to me. Reviewed-by: Liming Gao
<gaolim...@byosoft.com.cn>
Hao:
Have you time to review this fix?
Thanks
Liming
*发件人**:*devel@edk2.groups.io <devel@edk2.groups.io> *代表 *苏丽坤
*发送时间:* 2023年7月18日 9:49
*收件人:* gaolim...@byosoft.com.cn; miki.deme...@intel.com;
devel@edk2.groups.io
*主题:* [edk2-devel] empty USB DVD disk hang Xhci
Hi
We find a bug in xhci, USB DVD boot with emtpy disk will hang
Xhci while Ehci can pass.
The hang log is shown as :
MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c(1847): TrsRing != ((void
*) 0)
We suggest a way to solve this bug is shown as:
https://github.com/suling-123/edk2 the latest commit,
MdeModulePkg: Solve boot hang xhci driver when use USB DVD with
empty disk, 950bc8781d81b96b0c7944e7ac947382b1bc0c06
/本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。//
This email and its attachments contain confidential information
from Loongson Technology , which is intended only for the person
or entity whose address is listed above. Any use of the
information contained herein in any way (including, but not
limited to, total or partial disclosure, reproduction or
dissemination) by persons other than the intended recipient(s) is
prohibited. If you receive this email in error, please notify the
sender by phone or email immediately and delete it. /
/本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。//
This email and its attachments contain confidential information
from Loongson Technology , which is intended only for the person
or entity whose address is listed above. Any use of the
information contained herein in any way (including, but not
limited to, total or partial disclosure, reproduction or
dissemination) by persons other than the intended recipient(s) is
prohibited. If you receive this email in error, please notify the
sender by phone or email immediately and delete it. /
/本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。
This email and its attachments contain confidential information from
Loongson Technology , which is intended only for the person or entity
whose address is listed above. Any use of the information contained
herein in any way (including, but not limited to, total or partial
disclosure, reproduction or dissemination) by persons other than the
intended recipient(s) is prohibited. If you receive this email in
error, please notify the sender by phone or email immediately and
delete it. /
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107298): https://edk2.groups.io/g/devel/message/107298
Mute This Topic: https://groups.io/mt/100343121/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
