Reviewed-by: Hao A Wu <hao.a...@intel.com> Best Regards, Hao Wu
> -----Original Message----- > From: Ranbir Singh <rsi...@ventanamicro.com> > Sent: Monday, July 17, 2023 7:40 PM > To: devel@edk2.groups.io; rsi...@ventanamicro.com > Cc: Wu, Hao A <hao.a...@intel.com>; Ni, Ray <ray...@intel.com>; Veeresh > Sangolli <veeresh.sango...@dellteam.com> > Subject: [PATCH v1 1/1] MdeModulePkg/Bus/Pci/NvmExpressPei: Fix > DEADCODE Coverity issue > > From: Ranbir Singh <ranbir.sin...@dell.com> > > The code can reach line 65 only through the else path above at line 53. > The else path already has the same NULL check at line 55 and hence the > duplicate code lines are totally redundant which can be deleted. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4220 > > Cc: Hao A Wu <hao.a...@intel.com> > Cc: Ray Ni <ray...@intel.com> > Co-authored-by: Veeresh Sangolli <veeresh.sango...@dellteam.com> > Signed-off-by: Ranbir Singh <ranbir.sin...@dell.com> > Signed-off-by: Ranbir Singh <rsi...@ventanamicro.com> > --- > MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > index d704c62eaab3..1d03d4964025 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > +++ b/MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPeiS3.c > @@ -62,10 +62,6 @@ NvmeS3SkipThisController ( > } } - if (S3InitDevices == NULL) {- return Skip;- }- // // > Only need to > initialize the controllers that exist in the device list. //-- > 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107679): https://edk2.groups.io/g/devel/message/107679 Mute This Topic: https://groups.io/mt/100212115/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
