Hi Pierre, Please send an updated version with the r-b collected. That way it would be less work for the maintainer.
Regards, Sami Mujawar ________________________________ From: Pierre Gondois <pierre.gond...@arm.com> Sent: Thursday, August 10, 2023 6:49:40 PM To: Sami Mujawar <sami.muja...@arm.com>; devel@edk2.groups.io <devel@edk2.groups.io> Subject: Re: [edk2-devel] [PATCH v5 8/9] SecurityPkg/RngDxe: Use GetRngGuid() when probing RngLib Hi Sami, Yes indeed, this line should be removed, do you want me to send a new version of this patch ? Regards, Pierre On 8/7/23 07:16, Sami Mujawar wrote: > Hi Pierre, > > Thank you for this patch. > > On Tue, Jul 18, 2023 at 04:52 AM, PierreGondois wrote: > > + gEfiRngAlgorithmArmRndr ## SOMETIMES_PRODUCES ## GUID = > # Unique ID of the algorithm for RNG > > Can you check if the line above should be part of this patch, please? > Otherwise, this patch looks good to me. > > In either case, > Reviewed-by: Sami Mujawar <sami.muja...@arm.com> > > Regards, > > Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107699): https://edk2.groups.io/g/devel/message/107699 Mute This Topic: https://groups.io/mt/100213737/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
