W dniu 21.08.2023 o 20:27, Leif Lindholm pisze:
Hmm, wait. Patch 1/3 adds Iort.aslc and patch 3/3 deletes it. I know 1/3 is Shashi's original implementation and 3/3 is heavily based on that (if rewritten), but there's no point in merging the churn.
I kind of wanted to get review of both parts. First one (written by Shashi long time ago) and rest (written by me in last months). Whole testing was "does Linux boots and shows me complex PCIe structure". Can squash into one, no problem.
What does this set look like as a single squashed patch? (I think doing that would also address all previous comments I made.)
22:16 marcin@applejack:edk2-platforms$ git diff --stat origin/master Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 4 + Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 4 + Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 + Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 2 + Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.inf | 1 + Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuAcpi.h | 11 ++ Silicon/Qemu/SbsaQemu/Include/IndustryStandard/SbsaQemuSmc.h | 1 + Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 208 +++++++++++++++++++- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 10 + 9 files changed, 241 insertions(+), 1 deletion(-) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107936): https://edk2.groups.io/g/devel/message/107936 Mute This Topic: https://groups.io/mt/100874755/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
