Another option, when the main pipeline page says there is an uncrustify
error is to take the cmdline it ran with and append
UNCRUSTIFY_IN_PLACE=TRUE to it. It will then auto-fixup any uncrustify
errors (which obviously should be audited afterwards). I do this to
avoid having to wade through numerous errors, especially since I
almost always take whatever the auto-format provides.
For example, for your failure, if you ran:
stuart_ci_build -c .pytool/CISettings.py -p OvmfPkg -t NO-TARGET,NOOPT
-a IA32,X64,ARM,AARCH64,RISCV64,LOONGARCH64 TOOL_CHAIN_TAG=GCC5
UNCRUSTIFY_IN_PLACE=TRUE
It will autofix the issue.
Oliver
On 8/28/2023 11:19 AM, Taylor Beebe wrote:
Here's a git-patch so you can easily fix it:
---
OvmfPkg/IoMmuDxe/IoMmuBuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
index 2764c35044ac..d66763263784 100644
--- a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
+++ b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
@@ -434,7 +434,7 @@ IoMmuFreeBounceBuffer (
mReservedMemBitmap,
mReservedMemBitmap & ((UINT32)(~MapInfo->ReservedMemBitmap))
));
- MapInfo->PlainTextAddress = 0;
+ MapInfo->PlainTextAddress = 0;
ClearReservedMemBit (MapInfo->ReservedMemBitmap);
MapInfo->ReservedMemBitmap = 0;
}
--
On 8/28/2023 11:16 AM, Mike Maslenkin wrote:
Hello!
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=100301&view=ms.vss-test-web.build-test-results-tab&runId=877528&resultId=100006&paneView=attachments
Uncrustify found formatting errors in IoMmuDxe/IoMmuBuffer.c
See Standard_Error_Output.log in "attachments"
It doesn't like two spaces at assignment
MapInfo->PlainTextAddress_ _= 0;
Best Regards,
Mike
On Mon, Aug 28, 2023 at 8:58 PM Ard Biesheuvel<a...@kernel.org> wrote:
Could someone please explain to me how I can figure out why this PR
was rejected by the CI?
https://github.com/tianocore/edk2/pull/4763
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108064): https://edk2.groups.io/g/devel/message/108064
Mute This Topic: https://groups.io/mt/101015386/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
