Hi Mike, Yes, if you don't mind, please send v2 patch set for community review.
Thanks, Nickle > -----Original Message----- > From: Mike Maslenkin <mike.maslen...@gmail.com> > Sent: Tuesday, August 29, 2023 7:19 AM > To: devel@edk2.groups.io; Nickle Wang <nick...@nvidia.com> > Cc: abner.ch...@amd.com; ig...@ami.com > Subject: Re: [edk2-devel] [PATCH 0/5] RedfishClientPkg: fix issues with local > variables. > > External email: Use caution opening links or attachments > > > Hi Nickle, > > I incorporated changes required for uncrustify check. > Also I added additional patch with trivial spelling fixes. Do I need to > resend v.2 to > the list? > > Regards, > Mike. > > On Mon, Aug 28, 2023 at 12:03 PM Nickle Wang via groups.io > <nicklew=nvidia....@groups.io> wrote: > > > > Hi Mike, > > > > > I didn't find any codyng-style issues in uncrustify output. > > > > I fetch your branch and run uncrustify tool to fix error in vs code editor. > > I push > the fix to your branch at this commit for your reference: > https://github.co/ > m%2Fghbaccount%2Fedk2-redfish- > client%2Fcommit%2Ff22209f7bd5946168326a3197006d92856247d35&data=05 > %7C01%7Cnicklew%40nvidia.com%7Cd987118958794ea8bc9608dba81d308e%7 > C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C638288615556969633%7 > CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6 > Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=S2IV%2B5NbPjC40SJ1 > o0SUJLlDzeCoyiqGAHLYH%2Fg%2F0%2FA%3D&reserved=0 The uncrustify check > on PR is now passed successfully. My commit breaks patch check as expected, > please incorporate my changes with yours and do a force push to this PR again. > > > > For the way of fixing uncrustify error, I am using the instructions > > here: > > https://gith/ > > ub.com%2Ftianocore%2Ftianocore.github.io%2Fwiki%2FEDK-II-Code-Formatti > > ng%23recommended-usage-visual-studio-vs-code- > plugin&data=05%7C01%7Cnic > > > klew%40nvidia.com%7Cd987118958794ea8bc9608dba81d308e%7C43083d1572 > 7340c > > > 1b7db39efd9ccc17a%7C0%7C0%7C638288615556969633%7CUnknown%7CTWF > pbGZsb3d > > > 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D > %7C > > > 3000%7C%7C%7C&sdata=qVkcSqm9RB8TciZqDBWuwkrPQsoMXLlS9ObWeVMk% > 2BEg%3D&r > > eserved=0 > > > > Thanks, > > Nickle > > > > > -----Original Message----- > > > From: Mike Maslenkin <mike.maslen...@gmail.com> > > > Sent: Sunday, August 27, 2023 6:57 PM > > > To: devel@edk2.groups.io > > > Cc: abner.ch...@amd.com; Nickle Wang <nick...@nvidia.com>; > > > ig...@ami.com; Mike Maslenkin <mike.maslen...@gmail.com> > > > Subject: [PATCH 0/5] RedfishClientPkg: fix issues with local variables. > > > > > > External email: Use caution opening links or attachments > > > > > > > > > This patchset contains fixes that resolve crashes while working with > > > uninitialized variables and a number of fixes for of leaked memory. > > > Note: looks like uncrustify check is broken at > > > tianocore/edk2-redfish-client repo, the corresponding PR failed: > > > https://gi/ > > > > thub.co%2F&data=05%7C01%7Cnicklew%40nvidia.com%7Cd987118958794ea8b > c9 > > > > 608dba81d308e%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C63828 > 8615 > > > > 556969633%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2 > luMz > > > > IiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=37M4Ew20 > MNry1 > > > 8V6m1K%2FfKTazjM1ZORlVyvZgtroeRU%3D&reserved=0 > > > m%2Ftianocore%2Fedk2-redfish- > > > > client%2Fpull%2F46&data=05%7C01%7Cnicklew%40nvidia.com%7C7cf336153fb > > > > f4e2e821008dba6ec62e0%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0 > > > > %7C638287306436105158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > > > > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C > > > > &sdata=VUxJA017msZzRYd%2FAxi0KeZvLi2s0QI6uKgHsOuDdws%3D&reserved=0 > > > > > > I didn't find any codyng-style issues in uncrustify output. > > > > > > Cc: Abner Chang <abner.ch...@amd.com> > > > Cc: Nickle Wang <nick...@nvidia.com> > > > Cc: Igor Kulchytskyy <ig...@ami.com> > > > Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108077): https://edk2.groups.io/g/devel/message/108077 Mute This Topic: https://groups.io/mt/100988470/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
