Reviewed-by: Nickle Wang <[email protected]>
Regards,
Nickle
> -----Original Message-----
> From: Mike Maslenkin <[email protected]>
> Sent: Tuesday, August 29, 2023 4:01 PM
> To: [email protected]
> Cc: [email protected]; Nickle Wang <[email protected]>;
> [email protected]; Mike Maslenkin <[email protected]>
> Subject: [PATCH v2 4/6] RedfishClientPkg: fix memory leak during EFI variables
> write.
>
> External email: Use caution opening links or attachments
>
>
> Signed-off-by: Mike Maslenkin <[email protected]>
> ---
> .../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c | 6 +++++-
> RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 6 +++++-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git
> a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c
> b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c
> index 86684cc72e1e..6a72afed8715 100644
> --- a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c
> +++ b/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c
> @@ -424,7 +424,11 @@ SaveConfigLangMapList (
> gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid,
> VARIABLE_ATTRIBUTE_NV_BS, 0, NULL);
>
> }
>
>
>
> - return gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid,
> VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData);
>
> + Status = gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid,
> VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData);
>
> +
>
> + FreePool (VarData);
>
> +
>
> + return Status;
>
> }
>
>
>
> /**
>
> diff --git a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c
> b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c
> index 7ac6e885dea6..a892ced984c8 100644
> --- a/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c
> +++ b/RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c
> @@ -411,7 +411,11 @@ SaveETagList (
> gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid,
> VARIABLE_ATTRIBUTE_NV_BS, 0, NULL);
>
> }
>
>
>
> - return gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid,
> VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData);
>
> + Status = gRT->SetVariable (VariableName, &gEfiRedfishClientVariableGuid,
> VARIABLE_ATTRIBUTE_NV_BS, VarSize, (VOID *)VarData);
>
> +
>
> + FreePool (VarData);
>
> +
>
> + return Status;
>
> }
>
>
>
> /**
>
> --
> 2.32.0 (Apple Git-132)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108108): https://edk2.groups.io/g/devel/message/108108
Mute This Topic: https://groups.io/mt/101027006/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
