Hi Yuquan, On Mon, Sep 04, 2023 at 14:30:57 +0800, Yuquan Wang wrote: > Hi, Leif > On 2023-08-31 21:06, Leif wrote: > > I had to move one hunk (.dec change) from 2/3 to 1/3 in order to > not break bisect. > > If you're happy with the slightly modified version, I think this > is good to go in. Please let me know. > > > It' ok. > > In the second version of this series patches, in fact, I have moved the .dec > change into > 1/3. > > It is my fault that I forgot to add "Cc" to Ard, Leif and Graeme in my latest > version > of "xhci" patches. > The link is: https://edk2.groups.io/g/devel/message/106729
Understood, thanks. However, this version still breaks bisect: attempting to build at 1/3 or 2/3 leads to: --- /work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf(72): error 3000: PCD [gArmVirtSbsaQemuPlatformTokenSpaceGuid.PcdPlatformEhciBase] in [/work/git/edk2-platforms/Silicon/Qemu/SbsaQemu/AcpiTables/AcpiTables.inf] is not found in dependent packages: --- Also, I think Ard's comments on the ACPI changes still apply. Do you have a comment on that? Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108259): https://edk2.groups.io/g/devel/message/108259 Mute This Topic: https://groups.io/mt/101073211/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-