Hello Abdul,

On 9/23/23 06:22, Attar, AbdulLateef (Abdul Lateef) wrote:
[AMD Official Use Only - General]


Hi Jeff, Sami,

                 I’m not reviewer, just providing the opinion.

How about making it generic(generic to integer argument)  instead of single 
integer argument.

     IN        UINT64                  IntegerArgument

     IN         UINT64 **IntegerArgumentArray.*

Create the list(by making use of AmlVarListAddTail) of data object depends on 
IntergerArgument value.

Also, I think if data in data node is AML_ARG0(0x68), AML_ARG1…., then it will 
considered as Arg0, Arg1, ….etc.

Just to be sure, you would like the method generated by 
AmlCodeGenMethodRetNameStringIntegerArgument()
to take multiple integer argument ? This would allow to generate a function 
taking N input arguments like:

Method(MET0, N, Serialized, 3) {
  Return (MET1 (1, 2, ..., N))
}

It is true AmlCodeGenMethodRetNameStringIntegerArgument() takes a NumArgs 
parameter,
but currently NumArgs can only equal 1.

Is there a specific use case that you are looking to solve with this solution ?

Regards,
Pierre


Thanks

AbduL



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109123): https://edk2.groups.io/g/devel/message/109123
Mute This Topic: https://groups.io/mt/101436335/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to