Hi Abner, On Fri, Sep 29, 2023 at 09:09:25 +0000, Chang, Abner wrote: > We have done the review on these patches.
Still waiting for an R-b from Duke. Hmm, who doesn't seem to have been cc:d. > Are you the steward of this repo and able to grant AMD folks the > merge privilege? To Eric, Abdul and me. I'm not a github admin - Mike? But that reminds me, we should start adding github IDs in [] brackets after email, like we do for edk2/edk2-platforms. > Btw, do we have to create a PR against non OSI repo for merging or > we can just push it? Just push. But send out for review first. Are any of you attending the plugfest? If more maintainers are joining edk2-non-osi, maybe we should have a proper chat about it. Regards, Leif > Get Outlook for Android<https://aka.ms/AAb9ysg> > ________________________________ > From: Leif Lindholm <quic_llind...@quicinc.com> > Sent: Friday, September 29, 2023 1:39:07 AM > To: Xing, Eric <eric.x...@amd.com> > Cc: devel@edk2.groups.io <devel@edk2.groups.io>; Michael D Kinney > <michael.d.kin...@intel.com>; Attar, AbdulLateef (Abdul Lateef) > <abdullateef.at...@amd.com>; Chang, Abner <abner.ch...@amd.com> > Subject: Re: [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon > initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for > Silicon/AMD and Silicon/AMD/Vangogh > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Hi Eric, > > Thanks. > You didn't really need to rework the patch, but I do want to see the > Reviewed-by's from the other added people before merging. > > Best Regards, > > Leif > > On Thu, Sep 28, 2023 at 17:13:36 +0000, Xing, Eric wrote: > > [AMD Official Use Only - General] > > > > Thanks Leif for your quick response and reminder. I added Abner as CC in > > PATCH v2. > > Sorry troubling you, would you help review it again so I can get your > > approved with v2 patch? Thanks again. > > > > Eric > > > > -----Original Message----- > > From: Leif Lindholm <quic_llind...@quicinc.com> > > Sent: Friday, September 29, 2023 12:15 AM > > To: Xing, Eric <eric.x...@amd.com> > > Cc: devel@edk2.groups.io; Michael D Kinney <michael.d.kin...@intel.com>; > > Attar, AbdulLateef (Abdul Lateef) <abdullateef.at...@amd.com> > > Subject: Re: [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon > > initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for > > Silicon/AMD and Silicon/AMD/Vangogh > > > > Caution: This message originated from an External Source. Use proper > > caution when opening attachments, clicking links, or responding. > > > > > > +Abner > > > > Looks fine to me, but I'd like to have a Reviewed-by from Abner, Abdul, > > Duke. > > > > Best Regards, > > > > Leif > > > > On Thu, Sep 28, 2023 at 22:30:53 +0800, eric.x...@amd.com wrote: > > > From: Eric Xing <eric.x...@amd.com> > > > > > > Signed-off-by: Eric Xing <eric.x...@amd.com> > > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > > Cc: Leif Lindholm <quic_llind...@quicinc.com> > > > Cc: Abdul Lateef Attar <abdat...@amd.com> > > > Signed-off-by: Eric Xing <eric.x...@amd.com> > > > --- > > > Maintainers.txt | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/Maintainers.txt b/Maintainers.txt index c42d135..1d5dacb > > > 100644 > > > --- a/Maintainers.txt > > > +++ b/Maintainers.txt > > > @@ -58,6 +58,15 @@ Platform/Intel/CometlakeSiliconBinPkg > > > M: Kathappan Esakkithevar <kathappan.esakkithe...@intel.com> > > > M: Sai Chaganty <rangasai.v.chaga...@intel.com> > > > > > > +Silicon/AMD > > > +M: Abner Chang <abner.ch...@amd.com> > > > +M: Abdul Lateef Attar <abdat...@amd.com> > > > +M: Eric Xing <eric.x...@amd.com> > > > + > > > +Silicon/AMD/Vangogh > > > +M: Duke Zhai <duke.z...@amd.com> > > > +M: Eric Xing <eric.x...@amd.com> > > > + > > > Silicon/Ampere/AmpereAltraBinPkg > > > M: Nhi Pham <n...@os.amperecomputing.com> > > > M: Vu Nguyen <vungu...@os.amperecomputing.com> > > > -- > > > 2.17.1 > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109192): https://edk2.groups.io/g/devel/message/109192 Mute This Topic: https://groups.io/mt/101638924/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
