[AMD Official Use Only - General] Reviewed-by: Abner Chang <abner.ch...@amd.com>
> -----Original Message----- > From: Nickle Wang <nick...@nvidia.com> > Sent: Wednesday, October 18, 2023 9:08 PM > To: devel@edk2.groups.io > Cc: Chang, Abner <abner.ch...@amd.com>; Igor Kulchytskyy > <ig...@ami.com> > Subject: [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce > PcdRedfishSendReceiveTimeout > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > Introduce PCD PcdRedfishSendReceiveTimeout to RedfishDiscoverDxe > driver. The SendReceiveTimeout is hard-code value in Redfish discover > driver. With this PCD, platform owner can configure timeout value > easily. > > Signed-off-by: Nickle Wang <nick...@nvidia.com> > Cc: Abner Chang <abner.ch...@amd.com> > Cc: Igor Kulchytskyy <ig...@ami.com> > --- > RedfishPkg/RedfishPkg.dec | 5 +++++ > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf | 2 +- > RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 2 +- > 3 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec > index cdb1528cedc9..0f18865cea0b 100644 > --- a/RedfishPkg/RedfishPkg.dec > +++ b/RedfishPkg/RedfishPkg.dec > @@ -142,3 +142,8 @@ > # This PCD indicates that if BMC bootstrap credential service will be > disabled > by BIOS or not. > # > > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService| > FALSE|BOOLEAN|0x00001007 > + # > + # The EFI_REST_EX_HTTP_CONFIG_DATA.SendReceiveTimeout value that > RedfishDiscoverDxe driver > + # set to EFI_REST_EX_PROTOCOL. > + # > + > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT3 > 2|0x00001008 > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf > index 950098bf6a0d..c982056fd700 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf > @@ -54,4 +54,4 @@ > > [Pcd] > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDiscoverAccessModeInBand ## > CONSUMES > - > + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout ## > CONSUEMS > diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > index 17c88ad82db4..2f9e604f6cd6 100644 > --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c > @@ -877,7 +877,7 @@ AddAndSignalNewRedfishService ( > goto EXIT_FREE_CONFIG_DATA; > } > > - RestExHttpConfigData->SendReceiveTimeout = 5000; > + RestExHttpConfigData->SendReceiveTimeout = PcdGet32 > (PcdRedfishSendReceiveTimeout); > RestExHttpConfigData->HttpConfigData.HttpVersion = > HttpVersion11; > RestExHttpConfigData->HttpConfigData.LocalAddressIsIPv6 = > CheckIsIpVersion6 (NetworkInterface); > if (RestExHttpConfigData->HttpConfigData.LocalAddressIsIPv6) { > -- > 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109749): https://edk2.groups.io/g/devel/message/109749 Mute This Topic: https://groups.io/mt/102038456/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-