Hi Sami, On 10/12/23 14:33, Sami Mujawar wrote: > Hi Laszlo, > > Thank you for this patch. > These changes look good to me. > > Reviewed-by: Sami Mujawar <[email protected]> > > Tested by booting a Linux guest using Kvmtool guest firmware > (ArmVirtPkg/ArmVirtKvmTool.dsc) for AArch64. > Tested-by: Sami Mujawar <[email protected]>
your response is under a PcAtChipsetPkg patch -- that's not used in "ArmVirtPkg/ArmVirtKvmTool.dsc". Which patches did you mean your Tested-by for? Thanks! Laszlo > > Regards, > > Sami Mujawar > > On 12/10/2023, 10:25, "[email protected] <mailto:[email protected]> on > behalf of Laszlo Ersek via groups.io" <[email protected] > <mailto:[email protected]> on behalf of [email protected] > <mailto:[email protected]>> wrote: > > > PcatRealTimeClockRuntimeDxe seems to have copied the interface name > LibRtcVirtualNotifyEvent() from EmbeddedPkg's RealTimeClockLib class. > That's not right, for two reasons: > > > - PcatRealTimeClockRuntimeDxe doesn't consume "EmbeddedPkg.dec" in the > first place, > > > - in EmbeddedPkg, the RealTimeClockLib class API > LibRtcVirtualNotifyEvent() is about to be eliminated (it's a bogus API). > > > Rename the LibRtcVirtualNotifyEvent() function to VirtualNotifyEvent(), > and make it static. > > > Tested with booting OVMF. > > > Cc: Ray Ni <[email protected] <mailto:[email protected]>> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 > <https://bugzilla.tianocore.org/show_bug.cgi?id=4564> > Signed-off-by: Laszlo Ersek <[email protected] <mailto:[email protected]>> > --- > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > > diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c > b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c > index b600df487952..ca0cad9b0198 100644 > --- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c > +++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtcEntry.c > @@ -122,9 +122,10 @@ PcRtcEfiSetWakeupTime ( > @param[in] Event The Event that is being processed > @param[in] Context Event Context > **/ > +STATIC > VOID > EFIAPI > -LibRtcVirtualNotifyEvent ( > +VirtualNotifyEvent ( > IN EFI_EVENT Event, > IN VOID *Context > ) > @@ -220,7 +221,7 @@ InitializePcRtc ( > Status = gBS->CreateEventEx ( > EVT_NOTIFY_SIGNAL, > TPL_NOTIFY, > - LibRtcVirtualNotifyEvent, > + VirtualNotifyEvent, > NULL, > &gEfiEventVirtualAddressChangeGuid, > &mVirtualAddrChangeEvent > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109750): https://edk2.groups.io/g/devel/message/109750 Mute This Topic: https://groups.io/mt/101914676/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
