Hi Mike, Sorry for the delay. I remove all duplicated definitions in RedfishCrtLib.h. Please check new patch file here: https://edk2.groups.io/g/devel/message/109925
Thanks, Nickle > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nickle Wang > via groups.io > Sent: Thursday, August 3, 2023 2:08 PM > To: Mike Maslenkin <mike.maslen...@gmail.com>; devel@edk2.groups.io; Abner > Chang <abner.ch...@amd.com> > Cc: Igor Kulchytskyy <ig...@ami.com>; Nick Ramirez <nrami...@nvidia.com> > Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: multiple > definitions > of strncpy. > > External email: Use caution opening links or attachments > > > Thanks for your review, Mike! > > I am ok to remove all duplicated declarations in this file. @Abner Chang, any > concern? > > Thanks, > Nickle > > > -----Original Message----- > > From: Mike Maslenkin <mike.maslen...@gmail.com> > > Sent: Saturday, July 22, 2023 8:28 PM > > To: devel@edk2.groups.io; Nickle Wang <nick...@nvidia.com> > > Cc: Abner Chang <abner.ch...@amd.com>; Igor Kulchytskyy > > <ig...@ami.com>; Nick Ramirez <nrami...@nvidia.com> > > Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: multiple > > definitions of strncpy. > > > > External email: Use caution opening links or attachments > > > > > > There is no usage of strncpy with signature (char *, size_t, char *). > > I would suggest to remove this declaration at all. > > BTW there are duplicated declaration for memcmp, memset, strncmp. > > > > On Sat, Jul 22, 2023 at 11:18 AM Nickle Wang via groups.io > > <nicklew=nvidia....@groups.io> wrote: > > > > > > There are two definitions for strncpy() function in RedfishCrtLib.h > > > > > > Signed-off-by: Nickle Wang <nick...@nvidia.com> > > > Cc: Abner Chang <abner.ch...@amd.com> > > > Cc: Igor Kulchytskyy <ig...@ami.com> > > > Cc: Nick Ramirez <nrami...@nvidia.com> > > > --- > > > RedfishPkg/Include/Library/RedfishCrtLib.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/RedfishPkg/Include/Library/RedfishCrtLib.h > > > b/RedfishPkg/Include/Library/RedfishCrtLib.h > > > index 23c6acfca33e..a2c17d1b03fc 100644 > > > --- a/RedfishPkg/Include/Library/RedfishCrtLib.h > > > +++ b/RedfishPkg/Include/Library/RedfishCrtLib.h > > > @@ -3,6 +3,7 @@ > > > > > > Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> > > > (C) Copyright 2021 Hewlett Packard Enterprise Development LP<BR> > > > + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights > reserved. > > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > @@ -304,8 +305,7 @@ char * > > > strncpy ( > > > char *, > > > size_t, > > > - const char *, > > > - size_t > > > + const char * > > > ); > > > > > > int > > > -- > > > 2.17.1 > > > > > > > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109928): https://edk2.groups.io/g/devel/message/109928 Mute This Topic: https://groups.io/mt/100292360/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-