For the change of ShellPkg: Reviewed-by: Zhichao Gao <zhichao....@intel.com>
Thanks, Zhichao > -----Original Message----- > From: Sami Mujawar <sami.muja...@arm.com> > Sent: Tuesday, October 24, 2023 4:43 PM > To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kin...@intel.com>; > Liu, Zhiguang <zhiguang....@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn> > Cc: Pierre Gondois <pierre.gond...@arm.com>; Jeshua Smith > <jesh...@nvidia.com>; ardb+tianoc...@kernel.org; > quic_llind...@quicinc.com; Gao, Zhichao <zhichao....@intel.com>; > anshuman.khand...@arm.com; matteo.carl...@arm.com; > akanksha.ja...@arm.com; sibel.allin...@arm.com; n...@arm.com > Subject: Re: [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & > ETE support > > Dear MdePkg Maintainers, > > Can I have your review feedback for the first 2 patches in this series, > please? > > - MdePkg: MADT: Add Online capable flag in GICC > - MdePkg: MADT: Add TRBE interrupt to GICC > > I plan to merge this series by end of this week. > > Regards, > > Sami Mujawar > > On 23/10/2023 04:30 pm, Jeshua Smith wrote: > > This series has received: > > Reviewed-by: Pierre Gondois <pierre.gond...@arm.com> > > > > And also For 1-2,12-13: > > Reviewed-by: Leif Lindholm <quic_llind...@quicinc.com> > > > > Can this be merged? > > > > -----Original Message----- > > From: Pierre Gondois <pierre.gond...@arm.com> > > Sent: Friday, September 22, 2023 8:51 AM > > To: Sami Mujawar <sami.muja...@arm.com>; devel@edk2.groups.io > > Cc: ardb+tianoc...@kernel.org; quic_llind...@quicinc.com; > > michael.d.kin...@intel.com; gaolim...@byosoft.com.cn; > > zhiguang....@intel.com; zhichao....@intel.com; > > anshuman.khand...@arm.com; matteo.carl...@arm.com; > > akanksha.ja...@arm.com; sibel.allin...@arm.com; Jeshua Smith > > <jesh...@nvidia.com>; n...@arm.com > > Subject: Re: [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & > > ETE support > > > > External email: Use caution opening links or attachments > > > > > > Hi Sami, > > Thanks for the update: > > Reviewed-by: Pierre Gondois <pierre.gond...@arm.com> > > > > Regards, > > Pierre > > > > On 9/22/23 16:35, Sami Mujawar wrote: > >> This patch series provides the following updates: > >> - The patches 1 & 2 add the new fields introduced > >> in MADT (APIC table) by ACPI 6.5 and the patch > >> 7/11 updates the Acpiview MADT parser accordingly. > >> - The patches 3, 4 & 5 adds TRBE support to the MADT > >> table generator in DynamicTablesPkg. > >> - Patch 6/11 updates the FADT ACPI revision to 6.5. > >> - The patches 8, 9 & 10 add support to generate ETE > >> device nodes. > >> - The 3rd last last patch series fixes a bug wherein > >> the CPC token was incorrectly referenced. > >> - The last 2 patches in the series introduce helper > >> functions to detect if TRBE and ETE features are > >> supported. > >> > >> Updates from v2 patch series: > >> - Updated patch 5 to removed superfluous initialisation > >> of TRBE interrupt field for ACPI 6.4. > >> - Patch 12/13 introduces a helper function in ArmLib to > >> detect if TRBE is supported. > >> - Patch 13/13 introduces a helper function in ArmLib to > >> detect if ETE is supported. > >> > >> Updates from v1 patch series: > >> - Fixed issue with setting TRBE interrupt in patch 5/11. > >> > >> The changes can be seen at: > >> https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v3 > >> > >> Sami Mujawar (13): > >> MdePkg: MADT: Add Online capable flag in GICC > >> MdePkg: MADT: Add TRBE interrupt to GICC > >> DynamicTablesPkg: Add TRBE interrupt to GICC object > >> DynamicTablesPkg: Add TRBE interrupt to GICC object parser > >> DynamicTablesPkg: Update MADT generator for ACPI 6.5 > >> DynamicTablesPkg: Update FADT generator to ACPI 6.5 > >> ShellPkg: Acpiview: Update MADT parser for TRBE interrupt > >> DynamicTablesPkg: Add an ET info object to Arm namespace > >> DynamicTablesPkg: Add an ET info object parser > >> DynamicTablesPkg: Add ETE device to CPU node in AML > >> DynamicTablesPkg: Fix referencing of CPC token > >> ArmPkg/ArmLib: Add ArmHasTrbe () helper function > >> ArmPkg/ArmLib: Add ArmHasEte () helper function > >> > >> ArmPkg/Include/Chipset/AArch64.h > >> | 4 + > >> ArmPkg/Include/Library/ArmLib.h > >> | 25 +++ > >> ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c > >> | > 31 ++++ > >> DynamicTablesPkg/Include/ArmNameSpaceObjects.h > | 32 +++- > >> DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c > | 108 +++++------ > >> > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c > | 79 ++++---- > >> > DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuT > opologyGenerator.c | 188 +++++++++++++++++++- > >> > DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuT > opologyGenerator.h | 11 +- > >> > DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManager > ObjectParser.c | 11 +- > >> MdePkg/Include/IndustryStandard/Acpi65.h > >> | 4 > +- > >> > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser. > c | 48 ++++- > >> 11 files changed, 442 insertions(+), 99 deletions(-) > >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110083): https://edk2.groups.io/g/devel/message/110083 Mute This Topic: https://groups.io/mt/101522262/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
