On Wed, Oct 25, 2023 at 13:25:30 +0200, pierre.gond...@arm.com wrote: > From: Pierre Gondois <pierre.gond...@arm.com> > > Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different > versions of the protocol. The macro is neither used in edk2 nor > in edk2-platforms.
OK, so slight nitpick, but mainly because it parses a bit weirdly... *Will* it be used after this series is merged, or is this an update for completeness? > Signed-off-by: Pierre Gondois <pierre.gond...@arm.com> > --- > ArmPkg/Include/Library/ArmLib.h | 1 + > .../Include/Protocol/ArmScmiPerformanceProtocol.h | 13 ++++++++----- > 2 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/ArmLib.h > index 0169dbc1092c..7b2b2238fed9 100644 > --- a/ArmPkg/Include/Library/ArmLib.h > +++ b/ArmPkg/Include/Library/ArmLib.h > @@ -780,6 +780,7 @@ EFIAPI > ArmHasVhe ( > VOID > ); > + > #endif // MDE_CPU_AARCH64 > > #ifdef MDE_CPU_ARM > diff --git a/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h > b/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h > index 7e548e4765c2..8e8e05d5a5f6 100644 > --- a/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h > +++ b/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h > @@ -1,12 +1,12 @@ > /** @file > > - Copyright (c) 2017-2021, Arm Limited. All rights reserved. > + Copyright (c) 2017-2023, Arm Limited. All rights reserved. > > SPDX-License-Identifier: BSD-2-Clause-Patent > > - System Control and Management Interface V1.0 > - http://infocenter.arm.com/help/topic/com.arm.doc.den0056a/ > - DEN0056A_System_Control_and_Management_Interface.pdf > + System Control and Management Interface, latest version: I see this as a pattern throughout the series. But this statement will at some point become untrue; this implementation is written against a specific version. I think this version shold be reflected in the comment. (And that applies throughout the series.) > + - https://developer.arm.com/documentation/den0056/latest/ But I think the above is the most useful link. / Leif > + > **/ > > #ifndef ARM_SCMI_PERFORMANCE_PROTOCOL_H_ > @@ -14,7 +14,10 @@ > > #include <Protocol/ArmScmi.h> > > -#define PERFORMANCE_PROTOCOL_VERSION 0x10000 > +/// Arm Scmi performance protocol versions. > +#define PERFORMANCE_PROTOCOL_VERSION_V1 0x10000 > +#define PERFORMANCE_PROTOCOL_VERSION_V2 0x20000 > +#define PERFORMANCE_PROTOCOL_VERSION_V3 0x30000 > > #define ARM_SCMI_PERFORMANCE_PROTOCOL_GUID { \ > 0x9b8ba84, 0x3dd3, 0x49a6, {0xa0, 0x5a, 0x31, 0x34, 0xa5, 0xf0, 0x7b, > 0xad} \ > -- > 2.25.1 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110088): https://edk2.groups.io/g/devel/message/110088 Mute This Topic: https://groups.io/mt/102175810/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
