On Tue, 31 Oct 2023 at 13:30, Laszlo Ersek <[email protected]> wrote: > > On 10/30/23 15:36, Ard Biesheuvel wrote: > > On Fri, 27 Oct 2023 at 07:43, duntan <[email protected]> wrote: > >> > >> Use BaseIoLibIntrinsic.inf in dsc files. The > >> BaseIoLibIntrinsic supports Tdx and sev now. > >> The BaseIoLibIntrinsicSev will be removed in > >> the following patches. > >> > >> Signed-off-by: Dun Tan <[email protected]> > >> Cc: Ard Biesheuvel <[email protected]> > >> Cc: Jiewen Yao <[email protected]> > >> Cc: Jordan Justen <[email protected]> > >> Cc: Gerd Hoffmann <[email protected]> > >> Cc: Ray Ni <[email protected]> > > > > Reviewed-by: Ard Biesheuvel <[email protected]> > > While I agree that this patch *in itself* is (quite obviously) formally > correct, semantically it is wrong for OVMF; which is why I have NACKed > the whole series; see <https://edk2.groups.io/g/devel/message/110242>. > > (Just highlighting it here too, lest it get lost in the review thread.) >
Apologies, I missed that. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110410): https://edk2.groups.io/g/devel/message/110410 Mute This Topic: https://groups.io/mt/102215668/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
