On 11/14/23 17:34, Ranbir Singh wrote:

> Though you already gave R-b, the return statement needs to be added to
> explicitly and completely rule out ARRAY_OVERRUN issue by static
> analysis tools.
> 
>              ASSERT (Index < TypeMax);
> +
> +            if (Index == TypeMax) {
> +              CpuDeadLoop ();
> +              return EFI_OUT_OF_RESOURCES;
> +            }
> +

Works for me!

If the "return" there is the only change in the upcoming v4 of this
patch, then please just carry forward my R-b.

Thanks!
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111245): https://edk2.groups.io/g/devel/message/111245
Mute This Topic: https://groups.io/mt/102490513/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: 
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to