Hi Laszlo, Liming, Mike,
Please see my response inline marked [SAMI].
Regards,
Sami Mujawar
On 17/11/2023 09:20 am, Laszlo Ersek wrote:
On 11/15/23 04:19, Ashish Singhal via groups.io wrote:
Just like CPU _UID, ETE UID also needs to be unique so
use AcpiProcessorUid instead of CpuName
Signed-off-by: Ashish Singhal <ashishsin...@nvidia.com>
---
.../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Is this a fixup for the recent feature
[PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support
https://edk2.groups.io/g/devel/message/108996
?
If so, then I *think* this qualifies to be merged during the hard
feature freeze (+Liming +Mike), but:
[SAMI] I raised a bugzilla for this issue at
https://bugzilla.tianocore.org/show_bug.cgi?id=4600
and have also created a pull request at
https://github.com/tianocore/edk2/pull/5061.
This patch has also passed the CI checks when I did a draft pull request.
I am not sure if I can apply the push label as we are in the code freeze
stage.
Can you advise on how to proceed, please?
[/SAMI]
- I think we should have a "Fixes:" tag in the commit message (for
pointing out the commit that should have contained the code being
added/updated now)
- I think we should have a BZ too (also linked into the commit message).
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111483): https://edk2.groups.io/g/devel/message/111483
Mute This Topic: https://groups.io/mt/102709920/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
