Hi Liming, On 21/11/2023, 01:05, "gaoliming" <gaolim...@byosoft.com.cn <mailto:gaolim...@byosoft.com.cn>> wrote:
Sami: I am OK to merge this patch for this stable bug. I will add push label for https://github.com/tianocore/edk2/pull/5061 <https://github.com/tianocore/edk2/pull/5061> [SAMI] Thank you for picking this patch for the stable tag. Apparently, the patch does not seem to have merged. I am not sure if you have already applied the push label. Please let me know if there are any issues that I can help with. Regards, Sami Mujawar Thanks Liming > -----邮件原件----- > 发件人: Sami Mujawar <sami.muja...@arm.com <mailto:sami.muja...@arm.com>> > 发送时间: 2023年11月21日 0:07 > 收件人: Laszlo Ersek <ler...@redhat.com <mailto:ler...@redhat.com>>; Liming Gao > (Byosoft address) > <gaolim...@byosoft.com.cn <mailto:gaolim...@byosoft.com.cn>>; Michael Kinney > <michael.d.kin...@intel.com <mailto:michael.d.kin...@intel.com>>; > devel@edk2.groups.io <mailto:devel@edk2.groups.io>; ashishsin...@nvidia.com > <mailto:ashishsin...@nvidia.com>; quic_llind...@quicinc.com > <mailto:quic_llind...@quicinc.com>; > ardb+tianoc...@kernel.org <mailto:ardb+tianoc...@kernel.org>; > jbra...@nvidia.com <mailto:jbra...@nvidia.com> > 抄送: n...@arm.com <mailto:n...@arm.com> > 主题: edk2-stable202311: Re: [edk2-devel] [PATCH] DynamicTablesPkg: Fix > ETE _UID Creation > > Hi Laszlo, Liming, Mike, > > Please see my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > On 17/11/2023 09:20 am, Laszlo Ersek wrote: > > On 11/15/23 04:19, Ashish Singhal via groups.io wrote: > >> Just like CPU _UID, ETE UID also needs to be unique so > >> use AcpiProcessorUid instead of CpuName > >> > >> Signed-off-by: Ashish Singhal <ashishsin...@nvidia.com > >> <mailto:ashishsin...@nvidia.com>> > >> --- > >> .../Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 5 > ++++- > >> 1 file changed, 4 insertions(+), 1 deletion(-) > > Is this a fixup for the recent feature > > > > [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support > > https://edk2.groups.io/g/devel/message/108996 > > <https://edk2.groups.io/g/devel/message/108996> > > > > ? > > > > If so, then I *think* this qualifies to be merged during the hard > > feature freeze (+Liming +Mike), but: > > [SAMI] I raised a bugzilla for this issue at > https://bugzilla.tianocore.org/show_bug.cgi?id=4600 > <https://bugzilla.tianocore.org/show_bug.cgi?id=4600> > > and have also created a pull request at > https://github.com/tianocore/edk2/pull/5061 > <https://github.com/tianocore/edk2/pull/5061>. > > This patch has also passed the CI checks when I did a draft pull request. > > I am not sure if I can apply the push label as we are in the code freeze > stage. > > Can you advise on how to proceed, please? > > [/SAMI] > > > - I think we should have a "Fixes:" tag in the commit message (for > > pointing out the commit that should have contained the code being > > added/updated now) > > > > - I think we should have a BZ too (also linked into the commit message). > > > > Laszlo > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111543): https://edk2.groups.io/g/devel/message/111543 Mute This Topic: https://groups.io/mt/102720225/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
