Hi Abner,
I agree with your fixes.
This patch can be dropped from this set.
BTW, do I understand correctly, PR is not required because changes are trivial?
Regards,
Mike.
On Thu, Nov 23, 2023 at 6:06 AM Chang, Abner <abner.ch...@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Good to go. We can merge this after code freeze.
>
> Abner
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> > Abner via groups.io
> > Sent: Thursday, November 23, 2023 9:20 AM
> > To: Nickle Wang <nick...@nvidia.com>; Mike Maslenkin
> > <mike.maslen...@gmail.com>; devel@edk2.groups.io
> > Cc: ig...@ami.com
> > Subject: Re: [edk2-devel] [PATCH v2 3/3] RedfishPkg: fix searching for the
> > BMC-exposed USB NIC
> >
> > [AMD Official Use Only - General]
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > [AMD Official Use Only - General]
> >
> > HI Nickle and Mike,
> > I also have some fixes and revised BMC USB NIC library for searching BMC
> > exposed NIC.
> > Please don't not merge this patch set just for now. I will review this and
> > compare with the changes I have.
> >
> > Thanks
> > Abner
> >
> > > -----Original Message-----
> > > From: Nickle Wang <nick...@nvidia.com>
> > > Sent: Thursday, November 23, 2023 8:24 AM
> > > To: Mike Maslenkin <mike.maslen...@gmail.com>; devel@edk2.groups.io
> > > Cc: Chang, Abner <abner.ch...@amd.com>; ig...@ami.com
> > > Subject: RE: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed
> > > USB NIC
> > >
> > > Caution: This message originated from an External Source. Use proper
> > caution
> > > when opening attachments, clicking links, or responding.
> > >
> > >
> > > Reviewed-by: Nickle Wang <nick...@nvidia.com>
> > >
> > > Regards,
> > > Nickle
> > >
> > > > -----Original Message-----
> > > > From: Mike Maslenkin <mike.maslen...@gmail.com>
> > > > Sent: Thursday, November 23, 2023 8:01 AM
> > > > To: devel@edk2.groups.io
> > > > Cc: abner.ch...@amd.com; Nickle Wang <nick...@nvidia.com>;
> > > > ig...@ami.com
> > > > Subject: [PATCH v2 3/3] RedfishPkg: fix searching for the BMC-exposed
> > USB
> > > NIC
> > > >
> > > > External email: Use caution opening links or attachments
> > > >
> > > >
> > > > According to RedfishPkg/Readme.md document:
> > > > "The last byte of host-end USB NIC MAC address is the last byte of BMC-
> > end
> > > USB
> > > > NIC MAC address minus 1."
> > > >
> > > > It is necessary to subtract 1 from IpmiLanChannelMacAddress.
> > > >
> > > > Cc: Abner Chang <abner.ch...@amd.com>
> > > > Cc: Nickle Wang <nick...@nvidia.com>
> > > > Cc: Igor Kulchytskyy <ig...@ami.com>
> > > > Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com>
> > > > ---
> > > > .../PlatformHostInterfaceBmcUsbNicLib.c | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git
> > > >
> > >
> > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > fac
> > > > eBmcUsbNicLib.c
> > > >
> > >
> > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > fac
> > > > eBmcUsbNicLib.c
> > > > index 95900579118b..20ec89d4fcb0 100644
> > > > ---
> > > >
> > >
> > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInter
> > > fac
> > > > eBmcUsbNicLib.c
> > > > +++
> > > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostI
> > > > +++ nterfaceBmcUsbNicLib.c
> > > > @@ -738,8 +738,8 @@ HostInterfaceIpmiCheckMacAddress (
> > > > (VOID *)&IpmiLanChannelMacAddress.Addr,
> > > >
> > > > IpmiLanMacAddressSize - 1
> > > >
> > > > ) != 0) ||
> > > >
> > > > - (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] !=
> > > >
> > > > - *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1) - 1)
> > > >
> > > > + (IpmiLanChannelMacAddress.Addr[IpmiLanMacAddressSize - 1] - 1
> > > > + !=
> > > >
> > > > + *(UsbNicInfo->MacAddress + IpmiLanMacAddressSize - 1))
> > > >
> > > > )
> > > >
> > > > {
> > > >
> > > > DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " MAC address is not
> > > > matched.\n"));
> > > >
> > > > --
> > > > 2.32.0 (Apple Git-132)
> >
> >
> >
> >
> >
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111708): https://edk2.groups.io/g/devel/message/111708
Mute This Topic: https://groups.io/mt/102759080/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
