Reviewed-by: Nickle Wang <nick...@nvidia.com>
Regards, Nickle > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang, Abner > via groups.io > Sent: Tuesday, November 28, 2023 1:26 PM > To: devel@edk2.groups.io > Cc: Nickle Wang <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com>; > Mike Maslenkin <mike.maslen...@gmail.com> > Subject: [edk2-devel] [PATCH] RedfishPkg/HostInterfaceBmcUsbNic: Set default > Redfish service port > > Caution: This message originated from an External Source. Use proper caution > when opening attachments, clicking links, or responding. > > > From: Abner Chang <abner.ch...@amd.com> > > BZ #4607 > Create a PCD for the default Redfish service port. > > Signed-off-by: Abner Chang <abner.ch...@amd.com> > Cc: Nickle Wang <nick...@nvidia.com> > Cc: Igor Kulchytskyy <ig...@ami.com> > Cc: Mike Maslenkin <mike.maslen...@gmail.com> > --- > RedfishPkg/RedfishPkg.dec | 8 ++++++-- > .../PlatformHostInterfaceBmcUsbNicLib.inf | 1 + > .../PlatformHostInterfaceBmcUsbNicLib.c | 2 +- > 3 files changed, 8 insertions(+), 3 deletions(-) > > diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec > index e40538247c2..3ea9ff3ef7f 100644 > --- a/RedfishPkg/RedfishPkg.dec > +++ b/RedfishPkg/RedfishPkg.dec > @@ -141,12 +141,16 @@ > # specification for that. > # > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServiceUuid|L"00000000-0000- > 0000-0000-000000000000"|VOID*|0x00001006 > + # Use PCD to declare the Redfish service port, default set to port 443. > + # Platform can overide this value in platform DSC file. > + # > + > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServicePort|443|UINT16|0x00001007 > # > # This PCD indicates that if BMC bootstrap credential service will be > disabled by > BIOS or not. > # > - > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService|FA > LSE|BOOLEAN|0x00001007 > + > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService|FA > LSE|BOOLEAN|0x00001008 > # > # The EFI_REST_EX_HTTP_CONFIG_DATA.SendReceiveTimeout value that > RedfishDiscoverDxe driver > # set to EFI_REST_EX_PROTOCOL. > # > - > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|0 > x00001008 > + > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|0 > x00001009 > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac > eBmcUsbNicLib.inf > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac > eBmcUsbNicLib.inf > index f2c7d7fec89..838a1721a7a 100644 > --- > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac > eBmcUsbNicLib.inf > +++ > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac > eBmcUsbNicLib.inf > @@ -43,6 +43,7 @@ > [Pcd] > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishHostName ## CONSUMED > gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServiceUuid ## CONSUMED > + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishServicePort ## CONSUMED > > [Depex] > gIpmiProtocolGuid > diff --git > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac > eBmcUsbNicLib.c > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac > eBmcUsbNicLib.c > index 2938d54da65..7f295fe7f1c 100644 > --- > a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac > eBmcUsbNicLib.c > +++ > b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInterfac > eBmcUsbNicLib.c > @@ -244,7 +244,7 @@ RedfishPlatformHostInterfaceProtocolData ( > ); > > // RedfishServiceIpPort > - RedfishOverIpData->RedfishServiceIpPort = 0; > + RedfishOverIpData->RedfishServiceIpPort = PcdGet16 > (PcdRedfishServicePort); > > // RedfishServiceVlanId > RedfishOverIpData->RedfishServiceVlanId = ThisInstance->VLanId; > -- > 2.37.1.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111981): https://edk2.groups.io/g/devel/message/111981 Mute This Topic: https://groups.io/mt/102845949/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
