On 12/11/23 11:55, Gerd Hoffmann wrote:
>> + //
>> + // Work around shim's terminally broken use of the EFI memory attributes
>> + // protocol, by uninstalling it if requested on the QEMU command line.
>> + //
>> + // E.g.,
>> + // -fw_cfg opt/org.tianocore/UninstallMemAttrProtocol,string=y
>> + //
>> + // This is only needed on the first boot, when fbaa64.efi is being
>> invoked to
>> + // set the boot order variables. Subsequent boots involving GRUB are not
>> + // affected.
>> + //
(1) I think this last paragraph of the comment no longer applies; is
that right? We don't restrict the proto masking to first boot any longer
(i.e., in v3).
>> + Uninstall = FixedPcdGetBool (PcdUninstallMemAttrProtocol);
>> + QemuFwCfgParseBool ("opt/org.tianocore/UninstallMemAttrProtocol",
>> &Uninstall);
>> + if (Uninstall) {
>> + UninstallEfiMemoryAttributesProtocol ();
>> + }
>
> Can we please have a log message here, for both uninstall and
> keep-installed cases?
Good idea!
>
> Otherwise the patch looks good to me.
With those two updates (assuming I'm right about (1)):
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Thanks!
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112301): https://edk2.groups.io/g/devel/message/112301
Mute This Topic: https://groups.io/mt/103106391/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
