On Mon, Dec 11, 2023 at 03:09:19PM +0000, Pedro Falcato wrote: > On Mon, Dec 11, 2023 at 1:12 PM Sunil V L <suni...@ventanamicro.com> wrote: > > > > On Sun, Dec 10, 2023 at 07:51:12PM +0530, Dhaval Sharma wrote: > [...] > > > nit: Can we pick a log style here? Like <something>: <log message> > > > In this case, "CacheOpCacheRange: Performing ...". It's just prettier > > > and more greppable. > > > My interpretation of this was removing __func__ and instead having some > > > relevant text would make it more searchable. > > > And it kind of did make sense to me. I know many places __func__ is used > > > but this is just a perspective. > > > > > I think the comment meant to follow a standard logging format since > > there was no ":" and a space in original change. I prefer __func__ over > > this so that we don't need to update multiple lines in case function > > name gets changed. > > I definitely meant that __func__ should not be used for this as well. > You can't really search for an error message if you're doing > gratuitous printf formatting for no reason. > Linux even has a policy where user-facing strings (i.e logs) cannot > get broken up, even if you run out of line width. > Thanks Pedro. Do you mean __func__ should not be used at all in any of logging? Or is there a case where it is allowed vs not allowed?
Thanks, Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112307): https://edk2.groups.io/g/devel/message/112307 Mute This Topic: https://groups.io/mt/102967058/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
