On Thu, 14 Dec 2023 at 10:37, Mike Beaton <mjsbea...@gmail.com> wrote: > > > IOW, please don't send a v6 until the discussion comes to a conclusion. > > Apologies, I did _not_ see this before sending. > > > > - #if !defined (MDEPKG_NDEBUG) > > > + #if defined (__CC_ARM) || defined (__GNUC__) > > > > No, this is not going to be acceptable to me. You noted that only the > > ARM code seems to suffer from this issue, so surely, we can find a way > > to change this code that doesn't introduce spurious dependencies on > > the exact toolchain we are using. > > With all due respect, I believe that you are incorrect that this is > spurious. Please check the surrounding code (specifically, this > compiler dependency exactly matches - and is there because of - a > compiler dependency in the surrounding code). (Additionally, though it > doesn't affect the point either way, I thought this is what you had > spotted and were asking for, when previously saying "What about > GCC?"!) >
Indeed. I hadn't spotted the context, and actually (patch sent), we need to rip that code out entirely. So please consider this piece solved. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112518): https://edk2.groups.io/g/devel/message/112518 Mute This Topic: https://groups.io/mt/103166459/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
