Re: 回复: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config file Enabling

[Rebecca Cran]

Queued as https://github.com/tianocore/edk2/pull/5177 .

On 12/19/2023 6:02 AM, gaoliming wrote:

The change is good.

Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>

-----邮件原件-----
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Guo, Gua
发送时间: 2023年12月19日 15:32
收件人: devel@edk2.groups.io; Chen, Christine <yuwei.c...@intel.com>;
Rebecca Cran <rebe...@bsdio.com>; Gao, Liming
<gaolim...@byosoft.com.cn>
抄送: Feng, Bob C <bob.c.f...@intel.com>
主题: Re: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config
file Enabling

Hi @Gao, Liming and @Rebecca Cran

I may need to get your help for review it, any concern you can also share

for

us.

Thanks,
Gua

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yuwei
Chen
Sent: Friday, December 15, 2023 5:12 PM
To: devel@edk2.groups.io
Cc: Rebecca Cran <rebe...@bsdio.com>; Gao, Liming
<gaolim...@byosoft.com.cn>; Feng, Bob C <bob.c.f...@intel.com>
Subject: [edk2-devel] [PATCH] BaseTools: FMMT GuidTool Auto Select Config
file Enabling

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624

Currently, Python FMMT tool does not support automatically select
FMMTConf.ini file which saves GuidTool settings.
This patch supports this features.

Cc: Rebecca Cran <rebe...@bsdio.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Bob Feng <bob.c.f...@intel.com>

Signed-off-by: Yuwei Chen <yuwei.c...@intel.com>
---
  BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/Python/FMMT/core/GuidTools.py
b/BaseTools/Source/Python/FMMT/core/GuidTools.py
index a25681709b..f6bdeffa50 100644
--- a/BaseTools/Source/Python/FMMT/core/GuidTools.py
+++ b/BaseTools/Source/Python/FMMT/core/GuidTools.py
@@ -110,7 +110,7 @@ class GUIDTools:
          if os.environ['FmmtConfPath']:             self.tooldef_file =
os.path.join(os.environ['FmmtConfPath'], 'FmmtConf.ini')         else:-
PathList = os.environ['PATH']+            PathList =
os.environ['PATH'].split(os.pathsep)             for CurrentPath in

PathList:

if os.path.exists(os.path.join(CurrentPath, 'FmmtConf.ini')):
self.tooldef_file = os.path.join(CurrentPath, 'FmmtConf.ini')--
2.42.0.windows.2

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112772): https://edk2.groups.io/g/devel/message/112772
Mute This Topic: https://groups.io/mt/103261683/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-