[AMD Official Use Only - General]
Hi Sami,
Currently we are using the AML library and evaluating the
Dynamic Tables Framework.
Soon we will be publishing(upstreaming) the usage of AML library under the
edk2-platforms/Platform/AMD/AmdPlatformPkg.
Thanks
AbduL
From: Sami Mujawar <sami.muja...@arm.com>
Sent: Thursday, December 21, 2023 7:24 PM
To: Attar, AbdulLateef (Abdul Lateef) <abdullateef.at...@amd.com>;
devel@edk2.groups.io
Cc: Attar, AbdulLateef (Abdul Lateef) <abdullateef.at...@amd.com>; Pierre
Gondois <pierre.gond...@arm.com>; n...@arm.com
Subject: Re: [Resend PATCH v5 3/4] DynamicTablesPkg: Corrects function pointer
typedef of AML_PARSE_FUNCTION
Caution: This message originated from an External Source. Use proper caution
when opening attachments, clicking links, or responding.
Hi Abdul,
Thank you for this fix.
For Arm EFIAPI evaluates to nothing, hence we could not catch such issues.
Do you use the rest of the Dynamic Tables Framework? I guess we have not
included the calling convention at other places e.g.
https://github.com/tianocore/edk2/blob/master/DynamicTablesPkg/Include/AcpiTableGenerator.h#L217
Maybe we need to find and fix those issues as well.
In either case, this patch looks good to me.
Reviewed-by: Sami Mujawar
<sami.muja...@arm.com><mailto:sami.muja...@arm.com>
Regards,
Sami Mujawar
On 20/12/2023 09:38 am, Abdul Lateef Attar wrote:
From: Abdul Lateef Attar
<abdullateef.at...@amd.com><mailto:abdullateef.at...@amd.com>
Corrects the function pointer typedef AML_PARSE_FUNCTION,
otherwise some compiler like VS2019 gives error.
Cc: Pierre Gondois <pierre.gond...@arm.com><mailto:pierre.gond...@arm.com>
Cc: Sami Mujawar <sami.muja...@arm.com><mailto:sami.muja...@arm.com>
Signed-off-by: Abdul Lateef Attar
<abdullateef.at...@amd.com><mailto:abdullateef.at...@amd.com>
Reviewed-by: Pierre Gondois
<pierre.gond...@arm.com><mailto:pierre.gond...@arm.com>
---
DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
index 8e584d4930..d3a51a94c7 100644
--- a/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
+++ b/DynamicTablesPkg/Library/Common/AmlLib/Parser/AmlParser.c
@@ -100,8 +100,7 @@ AmlParseStream (
**/
typedef
EFI_STATUS
-EFIAPI
-(*AML_PARSE_FUNCTION) (
+(EFIAPI *AML_PARSE_FUNCTION)(
IN CONST AML_NODE_HEADER *Node,
IN AML_PARSE_FORMAT ExpectedFormat,
IN OUT AML_STREAM *FStream,
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112835): https://edk2.groups.io/g/devel/message/112835
Mute This Topic: https://groups.io/mt/103278520/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
