On 1/9/24 07:40, Chao Li wrote: > Hi Laszlo, > > > Thanks, > Chao > On 2024/1/8 22:02, Laszlo Ersek wrote: >> On 1/5/24 10:45, Chao Li wrote: >>> Moved the PlatformBootManagerLib to OvmfPkg and renamed to >>> PlatformBootManagerLibLight for easy use by other ARCH. >>> >>> Build-tested only (with "ArmVirtQemu.dsc"). >>> >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 >>> >>> Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> >>> Cc: Leif Lindholm <quic_llind...@quicinc.com> >>> Cc: Sami Mujawar <sami.muja...@arm.com> >>> Cc: Gerd Hoffmann <kra...@redhat.com> >>> Cc: Jiewen Yao <jiewen....@intel.com> >>> Cc: Lazlo Ersek <ler...@redhat.com> >>> Signed-off-by: Chao Li <lic...@loongson.cn> >>> --- >>> ArmVirtPkg/ArmVirtPkg.ci.yaml | 1 - >>> ArmVirtPkg/ArmVirtPkg.dec | 1 - >>> ArmVirtPkg/ArmVirtQemu.dsc | 2 +- >>> ArmVirtPkg/ArmVirtQemuKernel.dsc | 2 +- >>> .../Library/PlatformBootManagerLibLight}/PlatformBm.c | 0 >>> .../Library/PlatformBootManagerLibLight}/PlatformBm.h | 0 >>> .../PlatformBootManagerLib.inf | 7 +++---- >>> .../Library/PlatformBootManagerLibLight}/QemuKernel.c | 0 >>> OvmfPkg/OvmfPkg.dec | 4 ++++ >>> 9 files changed, 9 insertions(+), 8 deletions(-) >>> rename {ArmVirtPkg/Library/PlatformBootManagerLib => >>> OvmfPkg/Library/PlatformBootManagerLibLight}/PlatformBm.c (100%) >>> rename {ArmVirtPkg/Library/PlatformBootManagerLib => >>> OvmfPkg/Library/PlatformBootManagerLibLight}/PlatformBm.h (100%) >>> rename {ArmVirtPkg/Library/PlatformBootManagerLib => >>> OvmfPkg/Library/PlatformBootManagerLibLight}/PlatformBootManagerLib.inf >>> (92%) >>> rename {ArmVirtPkg/Library/PlatformBootManagerLib => >>> OvmfPkg/Library/PlatformBootManagerLibLight}/QemuKernel.c (100%) >>> >>> diff --git a/ArmVirtPkg/ArmVirtPkg.ci.yaml b/ArmVirtPkg/ArmVirtPkg.ci.yaml >>> index 506b0e72f0..b186d4eb42 100644 >>> --- a/ArmVirtPkg/ArmVirtPkg.ci.yaml >>> +++ b/ArmVirtPkg/ArmVirtPkg.ci.yaml >>> @@ -24,7 +24,6 @@ >>> ], >>> ## Both file path and directory path are accepted. >>> "IgnoreFiles": [ >>> - "Library/PlatformBootManagerLib/PlatformBm.c" >>> ] >>> }, >>> ## options defined .pytool/Plugin/CompilerPlugin >> You don't seem to be reinstating this under OvmfPkg, so I think the same >> source file under OvmfPkg will cause a CI failure. > > There was no CI failure, there was a PR for edk2 in the cover letter, > all of the CI are passed. > > https://github.com/tianocore/edk2/pull/5208
My mistake -- and looking closer, I understand the reason (for the successful build). In OvmfPkg.ci.yaml, EccCheck is skipped altogether. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113427): https://edk2.groups.io/g/devel/message/113427 Mute This Topic: https://groups.io/mt/103540123/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
