On 1/9/24 15:11, Gerd Hoffmann wrote:
> Hi,
>
>> Nit: to my knowledge, the coding style forbids initialization of "auto"
>> storage class variables (more commonly put, "non-static local
>> variables"). IOW, we should spell the above as:
>>
>> | diff --git a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c
>> b/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c
>> | index ca2e40743dfd..8fcd999ac6df 100644
>> | --- a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c
>> | +++ b/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c
>> | @@ -283,7 +283,9 @@ ValidateFvHeader (
>> |
>> | if (VarHeaderEnd >= VariableStoreHeader->Size) {
>> | if (VarOffset <= VariableStoreHeader->Size - sizeof (UINT16)) {
>> | - CONST UINT16 *StartId = (VOID *)((UINTN)VariableStoreHeader +
>> VarOffset);
>> | + CONST UINT16 *StartId;
>> | +
>> | + StartId = (VOID *)((UINTN)VariableStoreHeader + VarOffset);
>> | if (*StartId == 0x55aa) {
>> | DEBUG ((DEBUG_ERROR, "%a: startid at invalid location\n",
>> __func__));
>> | return EFI_NOT_FOUND;
>>
>> Do you want me to fix up the patch upon merge for you,
>
> I happily accept that service offer ;)
Series merged as commit range 08a6528bac38..4a443f73fd67, via
<https://github.com/tianocore/edk2/pull/5240>. (Last three commits in
the PR.)
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113484): https://edk2.groups.io/g/devel/message/113484
Mute This Topic: https://groups.io/mt/103617812/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
