Hi Liming, Thanks! I created a PR: https://github.com/tianocore/edk2/pull/5191 Could you help push it?
B.R. Junfeng -----Original Message----- From: gaoliming <gaolim...@byosoft.com.cn> Sent: Thursday, January 11, 2024 10:19 AM To: devel@edk2.groups.io; Guan, JunfengX <junfengx.g...@intel.com> Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Liu, Zhiguang <zhiguang....@intel.com>; Li, Yi1 <yi1...@intel.com> Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of the EFI_NVDIMM_LABEL Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Junfeng Guan > 发送时间: 2023年12月27日 9:57 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney <michael.d.kin...@intel.com>; Liming Gao > <gaolim...@byosoft.com.cn>; Zhiguang Liu <zhiguang....@intel.com>; Yi > Li <yi1...@intel.com> > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update the Label definitions of > the EFI_NVDIMM_LABEL > > Refer to Uefi spec 2.10 section 13.19.5, update the label definitions > for NVDIMM SPA location cookie. > > Signed-off-by: Junfeng Guan <junfengx.g...@intel.com> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang....@intel.com> > Cc: Yi Li <yi1...@intel.com> > --- > MdePkg/Include/Protocol/NvdimmLabel.h | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Protocol/NvdimmLabel.h > b/MdePkg/Include/Protocol/NvdimmLabel.h > index e46999a3ab4a..2352c9bd1652 100644 > --- a/MdePkg/Include/Protocol/NvdimmLabel.h > +++ b/MdePkg/Include/Protocol/NvdimmLabel.h > @@ -122,6 +122,12 @@ typedef struct { > /// > #define EFI_NVDIMM_LABEL_FLAGS_UPDATING 0x00000008 > > +/// > +/// When set, the SPALocationCookie in the namespace label is valid > +and > should match the > +/// current value in the NFIT SPA Range Structure. > +/// > +#define EFI_NVDIMM_LABEL_FLAGS_SPACOOKIE_BOUND 0x00000010 > + > typedef struct { > /// > /// Unique Label Identifier UUID per RFC 4122. > @@ -196,10 +202,18 @@ typedef struct { > /// > EFI_GUID AddressAbstractionGuid; > > + /// > + /// When creating the label, this value is set to the value from > + the NFIT > SPA Range Structure if the > + /// SPALocationCookie flag (bit 2) is set. If > EFI_NVDIMM_LABEL_FLAGS_SPACOOKIE_BOUND is set, the SPALocationCookie > + /// value stored in the namespace label should match the current > + value in > the NFIT SPA Range Structure. > + /// Otherwise, the data may not be read correctly. > + /// > + UINT64 SPALocationCookie; > + > /// > /// Shall be 0. > /// > - UINT8 Reserved1[88]; > + UINT8 Reserved1[80]; > > /// > /// 64-bit Fletcher64 checksum of all fields in this Label. > -- > 2.26.2.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113592): https://edk2.groups.io/g/devel/message/113592 Mute This Topic: https://groups.io/mt/103658299/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-