Hi All,
I had corrected the description, added the UEFI spec version and section
details . Please check and approve it
Thanks,
P. Madhan
-----Original Message-----
From: Pethaiyan, Madhan <madhan.pethai...@intel.com>
Sent: Monday, January 8, 2024 12:13 PM
To: devel@edk2.groups.io
Cc: Pethaiyan, Madhan <madhan.pethai...@intel.com>; Gao, Liming
<gaolim...@byosoft.com.cn>; Kinney, Michael D <michael.d.kin...@intel.com>; Xu,
Wei6 <wei6...@intel.com>
Subject: [PATCH V2] FmpDevicePkg: GetImageInfo Add missing condition
From: "Pethaiyan, Madhan" <madhan.pethai...@intel.com>
UEFI Spec 2.10 , 23.1 Firmware Management Protocol , Added missing condition
check under GetImageInfo function, if the PackageVersionName is NULL return
EFI_INVALID_PARAMETER
Signed-off-by: Pethaiyan Madhan <madhan.pethai...@intel.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kin...@intel.com>
Cc: Wei6 Xu <wei6...@intel.com>
---
FmpDevicePkg/FmpDxe/FmpDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/FmpDevicePkg/FmpDxe/FmpDxe.c b/FmpDevicePkg/FmpDxe/FmpDxe.c index
1e7ec4a09e..e87094f84c 100644
--- a/FmpDevicePkg/FmpDxe/FmpDxe.c
+++ b/FmpDevicePkg/FmpDxe/FmpDxe.c
@@ -495,7 +495,7 @@ GetTheImageInfo (
// Confirm that buffer isn't null
//
if ( (ImageInfo == NULL) || (DescriptorVersion == NULL) || (DescriptorCount
== NULL) || (DescriptorSize == NULL)
- || (PackageVersion == NULL))
+ || (PackageVersion == NULL) || (PackageVersionName == NULL))
{
DEBUG ((DEBUG_ERROR, "FmpDxe(%s): GetImageInfo() - Pointer Parameter is
NULL.\n", mImageIdName));
Status = EFI_INVALID_PARAMETER;
--
2.38.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114085): https://edk2.groups.io/g/devel/message/114085
Mute This Topic: https://groups.io/mt/103620853/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
