Hi Suqiang, The comment line added look like is exceeds 80 columns. Please reformat.
Also, there are implementations of this service in the edk2 repo. Please update those with this same function header update. Thanks, Mike > -----Original Message----- > From: Ren, SuqiangX <[email protected]> > Sent: Thursday, January 11, 2024 1:04 AM > To: [email protected] > Cc: Kinney, Michael D <[email protected]>; Gao, Liming > <[email protected]>; Liu, Zhiguang <[email protected]> > Subject: RE: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition > of FileName on EFI_FILE_INFO > > Hi All, > > Any comments about this patch? > > Thanks > Ren, Suqiang > > -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of Ren, > Suqiang > Sent: Tuesday, December 26, 2023 1:22 PM > To: [email protected] > Cc: Kinney, Michael D <[email protected]>; Gao, Liming > <[email protected]>; Liu, Zhiguang <[email protected]> > Subject: [edk2-devel] [PATCH V2 1/1] MdePkg: Update the definition of > FileName on EFI_FILE_INFO > > Add the description of FileName to align with UEFI spec 2.10. > > REF: UEFI spec 2.10 Table 13.5.16 > > Signed-off-by: Suqiang Ren <[email protected]> > Cc: Michael D Kinney <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Zhiguang Liu <[email protected]> > --- > MdePkg/Include/Guid/FileInfo.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Guid/FileInfo.h > b/MdePkg/Include/Guid/FileInfo.h index 2b7edf36aabc..c152789b40c8 100644 > --- a/MdePkg/Include/Guid/FileInfo.h > +++ b/MdePkg/Include/Guid/FileInfo.h > @@ -46,7 +46,7 @@ typedef struct { > /// > UINT64 Attribute; > /// > - /// The Null-terminated name of the file. > + /// The Null-terminated name of the file. For a root directory, the > name is an empty string. > /// > CHAR16 FileName[1]; > } EFI_FILE_INFO; > -- > 2.26.2.windows.1 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114159): https://edk2.groups.io/g/devel/message/114159 Mute This Topic: https://groups.io/mt/103366883/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
